code review 5731061: cmd/gc: must not inline panic, recover

cmd/gc: must not inline panic, recover

[rsc, 2012-03-05 18:44:39]

Hello lvd (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-03-05 18:47:43]

LGTM

(I assume the reasons is that the stack doesn't contain the right frame?)

On Mon, Mar 5, 2012 at 10:44 AM,  <rsc@golang.org> wrote:
> Reviewers: lvd,
>
> Message:
> Hello lvd (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/gc: must not inline panic, recover
>
> Please review this at http://codereview.appspot.com/5731061/
>
> Affected files:
>  M src/cmd/gc/inl.c
>  M test/escape4.go
>
>
> Index: src/cmd/gc/inl.c
> ===================================================================
> --- a/src/cmd/gc/inl.c
> +++ b/src/cmd/gc/inl.c
> @@ -182,6 +182,8 @@
>        case OCALLFUNC:
>        case OCALLINTER:
>        case OCALLMETH:
> +       case OPANIC:
> +       case ORECOVER:
>                if(debug['l'] < 4)
>                        return 1;
>                break;
> Index: test/escape4.go
> ===================================================================
> --- a/test/escape4.go
> +++ b/test/escape4.go
> @@ -31,3 +31,9 @@
>        }
>        f()
>  }
> +
> +func f2() {}  // ERROR "can inline f2"
> +
> +// No inline for panic, recover.
> +func f3() { panic(1) }
> +func f4() { recover() }
>
>

[rsc, 2012-03-05 18:51:32]

> (I assume the reasons is that the stack doesn't contain the right frame?)

Yes.  In general we don't inline things with calls;
these slipped through because they are special calls.
It is especially important not to inline recover, because
its definition depends on the meaning of "caller".

Russ

[rsc, 2012-03-05 18:51:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=733971e543a2 ***

cmd/gc: must not inline panic, recover

R=lvd, gri
CC=golang-dev
http://codereview.appspot.com/5731061

[lvd, 2012-03-05 19:09:18]

LGTM

On Mon, Mar 5, 2012 at 19:51, <rsc@golang.org> wrote:

> *** Submitted as
>
http://code.google.com/p/go/**source/detail?r=733971e543a2<http://code.google...
>
>
> cmd/gc: must not inline panic, recover
>
> R=lvd, gri
> CC=golang-dev
> http://codereview.appspot.com/**5731061<http://codereview.appspot.com/5731061>
>
>
>
http://codereview.appspot.com/**5731061/<http://codereview.appspot.com/5731061/>
>