Issue 5731048: code review 5731048: misc/cgo: re-enable some tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5731048: code review 5731048: misc/cgo: re-enable some tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by rsc

Modified:
13 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

misc/cgo: re-enable some tests The testso directory still needs to be enabled.

Patch Set 1 #

Patch Set 2 : diff -r ada18e5ef51f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 99a66fff2af2 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 99a66fff2af2 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 99a66fff2af2 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 61a5159136af https://code.google.com/p/go/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -121 lines)			Patch
R	misc/cgo/gmp/Makefile	View	1 2 3	1 chunk	+0 lines, -38 lines	0 comments	Download
M	misc/cgo/gmp/fib.go	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
M	misc/cgo/gmp/pi.go	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
R	misc/cgo/life/Makefile	View	1	1 chunk	+0 lines, -35 lines	0 comments	Download
M	misc/cgo/life/main.go	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	misc/cgo/life/test.bash	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
R	misc/cgo/stdio/Makefile	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download
M	misc/cgo/stdio/chain.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	misc/cgo/stdio/fib.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	misc/cgo/stdio/file.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	misc/cgo/stdio/hello.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	misc/cgo/stdio/test.bash	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	misc/cgo/test/basic.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	misc/cgo/test/callback.go	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	misc/cgo/test/callback_c.c	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	misc/cgo/test/issue1328.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	misc/cgo/test/issue1560.go	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/cmd/dist/build.c	View	1 2 3 4	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/pkg/go/build/build.go	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/run.bash	View	1 2 3 4	1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years ago (2012-03-07 03:42:16 UTC) #1

rsc

13 years ago (2012-03-07 04:27:33 UTC) #3

*** Submitted as 4f17a4370f1c ***

misc/cgo: re-enable some tests

The testso directory still needs to be enabled.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5731048

Expand All Messages | Collapse All Messages