Issue 57210046: code review 57210046: cmd/go: remove cross compiling restriction on cgo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 57210046: code review 57210046: cmd/go: remove cross compiling restriction on cgo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by elias.naur

Modified:
10 years, 2 months ago

Reviewers:
gobot, iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

cmd/go: remove cross compiling restriction on cgo A previous CL added support for cross compiling with cgo, but missed the GOOS check in cmd/go. Remove it. Update issue 4714

Patch Set 1 #

Patch Set 2 : diff -r ec5195954667 https://code.google.com/p/go #

Patch Set 3 : diff -r ec5195954667 https://code.google.com/p/go #

Patch Set 4 : diff -r 38cd458b1dfe https://code.google.com/p/go #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	src/cmd/go/build.go	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

elias.naur

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 2 months ago (2014-02-08 14:37:21 UTC) #1

elias.naur

On 2014/02/08 15:22:42, iant wrote: > LGTM This was LGTM'ed but never submitted. Was there ...

10 years, 2 months ago (2014-02-14 17:00:39 UTC) #3

iant

Sorry, I think I just forgot to submit it. And now it doesn't apply cleanly. ...

10 years, 2 months ago (2014-02-14 19:05:01 UTC) #4

elias.naur

Sure, PTAL. On 2014/02/14 19:05:01, iant wrote: > Sorry, I think I just forgot to ...

10 years, 2 months ago (2014-02-14 19:20:01 UTC) #5

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=5ed898064e8b *** cmd/go: remove cross compiling restriction on cgo A previous CL ...

10 years, 2 months ago (2014-02-14 19:36:55 UTC) #6

gobot

10 years, 2 months ago (2014-02-14 20:18:40 UTC) #7

Message was sent while issue was closed.

This CL appears to have broken the linux-arm-cheney-panda builder.

Expand All Messages | Collapse All Messages