Issue 5717049: code review 5717049: encoding/xml: fix xml test tag usage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5717049: code review 5717049: encoding/xml: fix xml test tag usage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by niemeyer

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

encoding/xml: fix xml test tag usage No real problem.

Patch Set 1 #

Patch Set 2 : code review 5717049: encoding/xml: fix xml test tag usage #

Patch Set 3 : code review 5717049: encoding/xml: fix xml test tag usage #

Patch Set 4 : diff -r faf3ea2e4979 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 096c7653c6b5 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	src/pkg/encoding/xml/marshal_test.go	View	1 2 3	3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-01 17:45:56 UTC) #1

rsc

LGTM Thanks. I wasn't sure if it was intentionally wrong (to test that).

13 years, 1 month ago (2012-03-01 17:54:39 UTC) #2

niemeyer

13 years, 1 month ago (2012-03-01 18:20:20 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a709380a8c86 ***

encoding/xml: fix xml test tag usage

No real problem.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5717049

Expand All Messages | Collapse All Messages