Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2322)

Issue 5715046: code review 5715046: sync: add Once example (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by dvyukov
Modified:
13 years, 1 month ago
Reviewers:
CC:
golang-dev, rsc, bradfitzgoog
Visibility:
Public.

Description

sync: add Once example

Patch Set 1 #

Patch Set 2 : diff -r a45cc1950c26 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a45cc1950c26 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 528b923d4258 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 528b923d4258 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r faf3ea2e4979 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/pkg/sync/example_test.go View 1 2 3 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 1 month ago (2012-03-01 12:00:42 UTC) #1
rsc
This is an unfortunate example, because it allocates the closure on each run. Better to ...
13 years, 1 month ago (2012-03-01 16:19:00 UTC) #2
bradfitzgoog
Does it have to allocate though? It doesn't close over anything and funcs can no ...
13 years, 1 month ago (2012-03-01 17:17:08 UTC) #3
rsc
On Thu, Mar 1, 2012 at 12:17, Brad Fitzpatrick <bradfitz@google.com> wrote: > Does it have ...
13 years, 1 month ago (2012-03-01 17:18:23 UTC) #4
dvyukov
Hello golang-dev@googlegroups.com, rsc@golang.org, bradfitz@google.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 1 month ago (2012-03-01 17:24:11 UTC) #5
rsc
LGTM
13 years, 1 month ago (2012-03-01 18:14:32 UTC) #6
dvyukov
13 years, 1 month ago (2012-03-01 18:16:25 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=096c7653c6b5 ***

sync: add Once example

R=golang-dev, rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/5715046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b