Issue 5714049: code review 5714049: runtime: run init on main thread

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5714049: code review 5714049: runtime: run init on main thread (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by rsc

Modified:
13 years, 1 month ago

Reviewers:
extraterrestrial, albert.strasheim

CC:
golang-dev, r, minux1

Visibility:
Public.

Description

runtime: run init on main thread Fixes issue 3125.

Patch Set 1 #

Patch Set 2 : diff -r aa7ded1d6fab https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r aa7ded1d6fab https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d9b20dc0a595 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -7 lines)			Patch
M	src/pkg/runtime/mheap.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/proc.c	View	1 2 3	3 chunks	+6 lines, -6 lines	0 comments	Download
A	src/pkg/runtime/runtime_linux_test.go	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-01 06:05:07 UTC) #1

minux1

should update the new creator of runtime·MHeap_Scavenger in comments of mheap.c

13 years, 1 month ago (2012-03-01 06:51:18 UTC) #3

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=e30fd0c700f6 *** runtime: run init on main thread Fixes issue 3125. R=golang-dev, ...

13 years, 1 month ago (2012-03-01 16:48:20 UTC) #4

albert.strasheim

--- FAIL: TestLockOSThread-16 (0.00 seconds) runtime_linux_test.go:27: pid=16934 but tid=16935 FAIL FAIL runtime 1.482s On 2012/03/01 ...

13 years, 1 month ago (2012-03-02 06:57:01 UTC) #5

rsc

Do you have any local modifications to the Go tree? Can you please run strace ...

13 years, 1 month ago (2012-03-02 16:21:04 UTC) #6

extraterrestrial

13 years, 1 month ago (2012-03-03 21:00:19 UTC) #7

On 2012/03/02 16:21:04, rsc wrote:
> Do you have any local modifications to the Go tree?
> Can you please run strace -f on the failing runtime.test binary?

https://groups.google.com/d/msg/golang-dev/lElfN4jRuMM/hx15VBlw8q8J

$ GOMAXPROCS=0 ./runtime.test 
PASS
$ GOMAXPROCS=2 ./runtime.test 
--- FAIL: TestLockOSThread-2 (0.00 seconds)
	runtime_linux_test.go:27: pid=8273 but tid=8274
FAIL

Expand All Messages | Collapse All Messages