Issue 5713044: code review 5713044: time: skip a often-flaky test in short mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5713044: code review 5713044: time: skip a often-flaky test in short mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by bradfitz

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

time: skip a often-flaky test in short mode In -test.short mode, skip measuring the upper bound of time sleeps. The API only guarantees minimum bounds on sleeps, anyway, so this isn't a bug we're ignoring as much as it is simply observing bad builder virtualization and/or loaded machines. We keep the test in full mode where developers will presumably be running on a lightly-loaded, native, fast machine.

Patch Set 1 #

Patch Set 2 : diff -r 8bdd36e45822 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8bdd36e45822 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b1f0c3b7a935 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/pkg/time/sleep_test.go	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-02-29 21:11:14 UTC) #1

bradfitz

13 years, 1 month ago (2012-02-29 21:14:14 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=37763a8d9c71 ***

time: skip a often-flaky test in short mode

In -test.short mode, skip measuring the upper bound of time
sleeps. The API only guarantees minimum bounds on sleeps,
anyway, so this isn't a bug we're ignoring as much as it is
simply observing bad builder virtualization and/or loaded
machines.

We keep the test in full mode where developers will
presumably be running on a lightly-loaded, native, fast
machine.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5713044

Expand All Messages | Collapse All Messages