Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(229)

Issue 5711052: code review 5711052: cmd/dist: recognize CC="ccache clang" as clang (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by rsc
Modified:
13 years ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

cmd/dist: recognize CC="ccache clang" as clang

Patch Set 1 #

Patch Set 2 : diff -r aa7ded1d6fab https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r aa7ded1d6fab https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 528b923d4258 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/dist/build.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years ago (2012-03-01 16:29:00 UTC) #1
gri
LGTM (But I don't see where "ccache" is checked for)
13 years ago (2012-03-01 16:31:26 UTC) #2
rsc
On Thu, Mar 1, 2012 at 11:31, <gri@golang.org> wrote: > LGTM > > (But I ...
13 years ago (2012-03-01 16:45:57 UTC) #3
rsc
13 years ago (2012-03-01 16:46:16 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=d9b20dc0a595 ***

cmd/dist: recognize CC="ccache clang" as clang

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5711052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b