Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(299)

Issue 5700056: code review 5700056: test/[n-z]*.go: add documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by r
Modified:
13 years, 1 month ago
Reviewers:
rsc
CC:
golang-dev, bradfitz, r2
Visibility:
Public.

Description

test/[n-z]*.go: add documentation

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r ccbda0007400 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -120 lines) Patch
M test/named1.go View 1 chunk +1 line, -0 lines 0 comments Download
M test/shift1.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/shift2.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/sieve.go View 1 chunk +3 lines, -2 lines 0 comments Download
M test/sigchld.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/simassign.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/sinit.go View 1 chunk +3 lines, -0 lines 0 comments Download
M test/sizeof.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/solitaire.go View 1 chunk +4 lines, -2 lines 0 comments Download
M test/stack.go View 1 chunk +1 line, -0 lines 0 comments Download
M test/string_lit.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/stringrange.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/struct0.go View 1 chunk +3 lines, -3 lines 0 comments Download
M test/switch.go View 2 chunks +13 lines, -0 lines 0 comments Download
R test/switch1.go View 1 chunk +0 lines, -20 lines 0 comments Download
M test/switch3.go View 1 chunk +3 lines, -0 lines 0 comments Download
R test/test0.go View 1 chunk +0 lines, -92 lines 0 comments Download
M test/turing.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/typeswitch.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/typeswitch1.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/typeswitch2.go View 1 chunk +3 lines, -0 lines 0 comments Download
M test/typeswitch3.go View 1 chunk +4 lines, -0 lines 0 comments Download
M test/undef.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/utf.go View 1 chunk +2 lines, -0 lines 0 comments Download
M test/varerr.go View 1 chunk +3 lines, -0 lines 0 comments Download
M test/varinit.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 1 month ago (2012-02-24 00:37:43 UTC) #1
bradfitz
LGTM http://codereview.appspot.com/5700056/diff/1/test/sigchld.go File test/sigchld.go (right): http://codereview.appspot.com/5700056/diff/1/test/sigchld.go#newcode8 test/sigchld.go:8: // Test that a program can survive the ...
13 years, 1 month ago (2012-02-24 00:46:26 UTC) #2
r2
On Feb 24, 2012, at 11:46 AM, bradfitz@golang.org wrote: > LGTM > > > > ...
13 years, 1 month ago (2012-02-24 00:47:34 UTC) #3
r
*** Submitted as http://code.google.com/p/go/source/detail?r=b18d4cb1f1d3 *** test/[n-z]*.go: add documentation R=golang-dev, bradfitz, r CC=golang-dev http://codereview.appspot.com/5700056
13 years, 1 month ago (2012-02-24 00:48:24 UTC) #4
rsc
13 years, 1 month ago (2012-02-24 00:49:47 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b