Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(906)

Issue 5699083: code review 5699083: text/template: add examples that use multiple templates (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by r
Modified:
13 years, 1 month ago
Reviewers:
CC:
golang-dev, peterthrun_ymail.com, adg
Visibility:
Public.

Description

text/template: add examples that use multiple templates Fixes issue 2742.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 9fa2b8dc359b https://code.google.com/p/go/ #

Total comments: 4

Patch Set 3 : diff -r c8afb6fb97a0 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c8afb6fb97a0 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 4aa8b95bb2bf https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -0 lines) Patch
A src/pkg/text/template/examplefiles_test.go View 1 2 3 1 chunk +182 lines, -0 lines 0 comments Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 1 month ago (2012-02-27 07:07:55 UTC) #1
peterthrun_ymail.com
I think it will be helpful to include an example similar to these with the ...
13 years, 1 month ago (2012-02-27 16:01:13 UTC) #2
r
Hello golang-dev@googlegroups.com, peterthrun@ymail.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 1 month ago (2012-02-28 03:51:51 UTC) #3
adg
http://codereview.appspot.com/5699083/diff/1/src/pkg/text/template/examplefiles_test.go File src/pkg/text/template/examplefiles_test.go (right): http://codereview.appspot.com/5699083/diff/1/src/pkg/text/template/examplefiles_test.go#newcode46 src/pkg/text/template/examplefiles_test.go:46: testGlob := []templateFile{ s/testGlob/helperFiles/ http://codereview.appspot.com/5699083/diff/3002/src/pkg/text/template/examplefiles_test.go File src/pkg/text/template/examplefiles_test.go (right): http://codereview.appspot.com/5699083/diff/3002/src/pkg/text/template/examplefiles_test.go#newcode44 ...
13 years, 1 month ago (2012-02-29 04:13:16 UTC) #4
r
Hello golang-dev@googlegroups.com, peterthrun@ymail.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 1 month ago (2012-03-01 00:52:05 UTC) #5
adg
LGTM
13 years, 1 month ago (2012-03-01 03:32:58 UTC) #6
r
13 years, 1 month ago (2012-03-01 03:55:27 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=1e7ecf40d9e9 ***

text/template: add examples that use multiple templates

Fixes issue 2742.

R=golang-dev, peterthrun, adg
CC=golang-dev
http://codereview.appspot.com/5699083
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b