Issue 5698078: code review 5698078: strings: make Count example show results

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5698078: code review 5698078: strings: make Count example show results (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by gri

Modified:
13 years ago

Reviewers:

CC:
iant, golang-dev

Visibility:
Public.

Description

strings: make Count example show results Thanks to dr.volker.dobler for tracking this down. Filed a long-term issue (3142) which may eventually resolve this problem w/o the need for a manual fix.

Patch Set 1 #

Patch Set 2 : diff -r e62a4f90e86a https://code.google.com/p/go #

Patch Set 3 : diff -r e62a4f90e86a https://code.google.com/p/go #

Patch Set 4 : diff -r e62a4f90e86a https://code.google.com/p/go #

Patch Set 5 : diff -r e62a4f90e86a https://code.google.com/p/go #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/strings/example_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

13 years ago (2012-02-27 20:12:11 UTC) #1

gri

Hello iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years ago (2012-02-27 20:13:22 UTC) #2

gri

13 years ago (2012-02-27 20:22:15 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b744455d742c ***

strings: make Count example show results

Thanks to dr.volker.dobler for tracking this down.

Filed a long-term issue (3142) which may eventually
resolve this problem w/o the need for a manual fix.

R=iant
CC=golang-dev
http://codereview.appspot.com/5698078

Expand All Messages | Collapse All Messages