code review 5698054: test/[n-r]*.go: add documentation

test/[n-r]*.go: add documentation
The rename ones needed redoing.

[r, 2012-02-23 23:14:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-02-23 23:20:04]

LGTM

On Fri, Feb 24, 2012 at 10:14 AM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test/[n-r]*.go: add documentation
> The rename ones needed redoing.
>
> Please review this at
http://codereview.appspot.com/**5698054/<http://codereview.appspot.com/5698054/>
>
> Affected files:
>  M test/nil.go
>  M test/nilptr.go
>  M test/parentype.go
>  M test/peano.go
>  M test/printbig.go
>  M test/range.go
>  M test/recover3.go
>  M test/rename.go
>  M test/rename1.go
>  M test/reorder.go
>  M test/reorder2.go
>  M test/rune.go
>  M test/runtime.go
>
>
>

[rsc, 2012-02-23 23:25:21]

LGTM

I am not convinced that rename.go and rename1.go are valid programs.
I expected that setting iota in the const block would preclude its use
elsewhere (which is why the tests didn't use iota before).  The fact that
those programs (presumably) run might itself be a bug.

Can check in for now assuming it runs but please file an issue for us
to figure out whether it should.

[r, 2012-02-23 23:30:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=dbaa69d14601 ***

test/[n-r]*.go: add documentation
The rename ones needed redoing.

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5698054