code review 5696079: net: make -external flag for tests default to true

net: make -external flag for tests default to true

go test -short # like in the build; no external stuff
go test # long tests, + external
go test -external=false # long tests, no external

[mikio, 2012-02-26 10:25:47]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-02-28 15:43:09]

I am a little worried about us never using the external tests anymore.
Can we make external default to true and make sure that all the
mentions use testing.Short() || !*testExternal?  Then you can run

go test -short  # like in the build; no external stuff
go test # long tests, + external
go test -external=false  # long tests, no external

[mikio, 2012-02-28 22:44:34]

On Wed, Feb 29, 2012 at 12:43 AM, Russ Cox <rsc@golang.org> wrote:

> Can we make external default to true and make sure that all the
> mentions use testing.Short() || !*testExternal?

Sure.

[mikio, 2012-02-29 01:25:27]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-02-29 16:20:46]

LGTM

Thanks.

http://codereview.appspot.com/5696079/diff/8005/src/pkg/net/lookup_test.go
File src/pkg/net/lookup_test.go (right):

http://codereview.appspot.com/5696079/diff/8005/src/pkg/net/lookup_test.go#ne...
src/pkg/net/lookup_test.go:15: var testExternal = flag.Bool("external", true,
"allow use of external networks during test")
s/during/during long/

[mikio, 2012-02-29 22:39:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=7bde1715f288 ***

net: make -external flag for tests default to true

go test -short # like in the build; no external stuff
go test # long tests, + external
go test -external=false # long tests, no external

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5696079