Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2540)

Issue 5688054: code review 5688054: openpgp: fix error strings and typos. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by agl1
Modified:
12 years, 2 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

openpgp: fix error strings and typos. Fixes issue 2841.

Patch Set 1 #

Patch Set 2 : diff -r 2a94d2b48f78 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 2a94d2b48f78 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 2a94d2b48f78 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r 2a94d2b48f78 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M openpgp/errors/errors.go View 1 2 3 4 6 chunks +7 lines, -7 lines 0 comments Download
M openpgp/packet/config.go View 1 1 chunk +1 line, -2 lines 0 comments Download
M openpgp/packet/signature.go View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://agl%40golang.org@code.google.com/p/go.crypto/
12 years, 2 months ago (2012-02-20 16:18:59 UTC) #1
rsc
LGTM I think it is more common to write the errors as nouns: invalid data, ...
12 years, 2 months ago (2012-02-20 17:14:09 UTC) #2
agl1
On Mon, Feb 20, 2012 at 12:14 PM, Russ Cox <rsc@golang.org> wrote: > I think ...
12 years, 2 months ago (2012-02-21 14:51:34 UTC) #3
agl1
12 years, 2 months ago (2012-02-21 14:52:41 UTC) #4
*** Submitted as 080d73e214b6 ***

openpgp: fix error strings and typos.

Fixes issue 2841.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5688054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b