Issue 5687065: code review 5687065: html/template: make doctype check case-insensitive

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5687065: code review 5687065: html/template: make doctype check case-insensitive (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bytbox

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc, nigeltao

Visibility:
Public.

Description

html/template: make doctype check case-insensitive Fixes issue 3094.

Patch Set 1 #

Patch Set 2 : diff -r 9f1cd67703bd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9f1cd67703bd https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/html/template/escape.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/html/template/escape_test.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bytbox

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-21 16:45:55 UTC) #1

nigeltao

On 22 February 2012 03:45, <bytbox@gmail.com> wrote: > Description: > html/template: make doctype check case-insensitive ...

12 years, 2 months ago (2012-02-21 23:06:21 UTC) #3

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=ccbda0007400 *** html/template: make doctype check case-insensitive Fixes issue 3094. R=golang-dev, rsc, ...

12 years, 2 months ago (2012-02-24 00:32:41 UTC) #5

For the review log: Mike Samuel LGTMed this off list.

Expand All Messages | Collapse All Messages