LGTM On Feb 20, 2012 10:49 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: ...
13 years, 1 month ago
(2012-02-20 12:21:31 UTC)
#2
LGTM
On Feb 20, 2012 10:49 PM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> doc/go1: delete obsolete reference to FileStat
> Fixes issue 3013.
>
> Please review this at
http://codereview.appspot.com/**5683049/<http://codereview.appspot.com/5683049/>
>
> Affected files:
> M doc/go1.html
> M doc/go1.tmpl
>
>
> Index: doc/go1.html
> ==============================**==============================**=======
> --- a/doc/go1.html
> +++ b/doc/go1.html
> @@ -1505,8 +1505,8 @@
> The system-specific details of file modes and properties such as (on Unix)
> i-number have been removed from <code>FileInfo</code> altogether.
> Instead, each operating system's <code>os</code> package provides an
> -implementation of the <code>FileInfo</code> interface,
> <code>*os.FileStat</code>,
> -which has a <code>Sys</code> method that returns the
> +implementation of the <code>FileInfo</code> interface, which
> +has a <code>Sys</code> method that returns the
> system-specific representation of file metadata.
> For instance, to discover the i-number of a file on a Unix system, unpack
> the <code>FileInfo</code> like this:
> Index: doc/go1.tmpl
> ==============================**==============================**=======
> --- a/doc/go1.tmpl
> +++ b/doc/go1.tmpl
> @@ -1408,8 +1408,8 @@
> The system-specific details of file modes and properties such as (on Unix)
> i-number have been removed from <code>FileInfo</code> altogether.
> Instead, each operating system's <code>os</code> package provides an
> -implementation of the <code>FileInfo</code> interface,
> <code>*os.FileStat</code>,
> -which has a <code>Sys</code> method that returns the
> +implementation of the <code>FileInfo</code> interface, which
> +has a <code>Sys</code> method that returns the
> system-specific representation of file metadata.
> For instance, to discover the i-number of a file on a Unix system, unpack
> the <code>FileInfo</code> like this:
>
>
>
Issue 5683049: code review 5683049: doc/go1: delete obsolete reference to FileStat
(Closed)
Created 13 years, 1 month ago by r
Modified 13 years, 1 month ago
Reviewers:
Base URL:
Comments: 0