Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(363)

Issue 56770045: code review 56770045: go/parser: better error messages for if/switch/for cond... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by gri
Modified:
10 years, 1 month ago
Reviewers:
adonovan
CC:
adonovan, golang-codereviews
Visibility:
Public.

Description

go/parser: better error messages for if/switch/for conditions/expressions Fixes issue 7102.

Patch Set 1 #

Patch Set 2 : diff -r 652a653e2809 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 652a653e2809 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5a1fe1cc299c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/pkg/go/parser/parser.go View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/go/parser/short_test.go View 1 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 3
gri
Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 1 month ago (2014-02-12 00:32:39 UTC) #1
adonovan
On 2014/02/12 00:32:39, gri wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...
10 years, 1 month ago (2014-02-12 00:37:34 UTC) #2
gri
10 years, 1 month ago (2014-02-12 00:45:35 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=39f83e05dec3 ***

go/parser: better error messages for if/switch/for conditions/expressions

Fixes issue 7102.

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/56770045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b