code review 5675095: cmd/dist: fix pprof permissions

cmd/dist: fix pprof permissions

When installing pprof into the tools directory, it needs to
have execute permissions on unix-like systems.

Fixes issues 3077.

[bpowers, 2012-02-19 03:56:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bpowers, 2012-02-19 03:57:46]

On 2012/02/19 03:56:50, bpowers wrote:
> Hello
https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

Frankly I'm not sure if this is the right approach, and I've only tested this on
Linux.  Suggestions/comments?

Bobby

[rsc, 2012-02-19 05:01:29]

I would instead add an 'int exec' parameter to writefile,
and pass a 1 explicitly for misc/pprof and leave it 0
the rest of the time.  Only unix.c would then need
to chmod +x the output.

[bpowers, 2012-02-19 05:31:02]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[minux1, 2012-02-19 05:38:28]

http://codereview.appspot.com/5675095/diff/6003/src/cmd/dist/windows.c
File src/cmd/dist/windows.c (right):

http://codereview.appspot.com/5675095/diff/6003/src/cmd/dist/windows.c#newcod...
src/cmd/dist/windows.c:542: writefile(Buf *b, char *file, int exec)
please add USED(exec)

[bpowers, 2012-02-19 05:54:59]

Hello golang-dev@googlegroups.com, rsc@golang.org, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[minux1, 2012-02-21 07:35:41]

Please add "Fixes issue 3077“ to description (Also, IMO, the description don't
need to be
that verbose).
LGTM.

[bpowers, 2012-02-21 13:46:52]

Hello golang-dev@googlegroups.com, rsc@golang.org, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bpowers, 2012-02-21 13:47:36]

Thanks for the review and suggestions!

On Tue, Feb 21, 2012 at 2:35 AM,  <minux.ma@gmail.com> wrote:
> Please add "Fixes issue 3077“ to description (Also, IMO, the description
> don't need to be
> that verbose).
> LGTM.
>
> http://codereview.appspot.com/5675095/

[rsc, 2012-02-21 21:47:29]

LGTM

[rsc, 2012-02-21 21:49:33]

*** Submitted as http://code.google.com/p/go/source/detail?r=7d0f321ea87c ***

cmd/dist: fix pprof permissions

When installing pprof into the tools directory, it needs to
have execute permissions on unix-like systems.

Fixes issues 3077.

R=golang-dev, rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/5675095

Committer: Russ Cox <rsc@golang.org>