LGTM *File.Fd() also returns uintptr now, instead of int (matching NewFile) On Wed, Feb 15, ...
12 years, 3 months ago
(2012-02-15 03:18:12 UTC)
#3
LGTM
*File.Fd() also returns uintptr now, instead of int (matching NewFile)
On Wed, Feb 15, 2012 at 2:17 PM, <adg@golang.org> wrote:
> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> doc: fix snapshot notes
>
> Please review this at
http://codereview.appspot.com/**5675056/<http://codereview.appspot.com/5675056/>
>
> Affected files:
> M doc/devel/weekly.html
>
>
> Index: doc/devel/weekly.html
> ==============================**==============================**=======
> --- a/doc/devel/weekly.html
> +++ b/doc/devel/weekly.html
> @@ -22,8 +22,8 @@
> The flate, gzip and zlib's NewWriterXxx functions no longer return an
> error.
> The compiler will flag all affected code which must then be updated by
> hand.
>
> -The os package's Exec and Time functions were removed. Callers should use
> the
> -os/exec package and time.Now instead. The ShellExpand function was
> renamed to
> +The os package's Exec and Time functions were removed. Callers should use
> +syscall.Exec and time.Now instead. The ShellExpand function was renamed to
> ExpandEnv. The NewFile function now takes a uintptr.
>
> The runtime package's Type type and its methods have been removed.
>
>
>
Issue 5675056: code review 5675056: doc: fix snapshot notes
(Closed)
Created 12 years, 3 months ago by adg
Modified 12 years, 3 months ago
Reviewers:
Base URL:
Comments: 0