Issue 5674112: code review 5674112: test: commentary for [h-m]*.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5674112: code review 5674112: test: commentary for [h-m]*.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by r

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Patch Set 2 : diff -r d2cabd44712c https://code.google.com/p/go/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -11 lines)			Patch
M	test/helloworld.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/if.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/import.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/import1.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/import2.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/import3.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/import4.go	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/import5.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/index.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/indirect.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/indirect1.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/init.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/initialize.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/initializerr.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/int_lit.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/intcvt.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/iota.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/label.go	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	test/label1.go	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	test/linkx.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/literal.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mallocfin.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/map.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/map1.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/method.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/method1.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/method2.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/method3.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 1 month ago (2012-02-19 12:32:56 UTC) #1

gri

LGTM http://codereview.appspot.com/5674112/diff/1/test/import2.go File test/import2.go (right): http://codereview.appspot.com/5674112/diff/1/test/import2.go#newcode7 test/import2.go:7: // Many declarations of exported variables and functions. ...

13 years, 1 month ago (2012-02-23 07:29:01 UTC) #2

13 years, 1 month ago (2012-02-23 07:47:31 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e2fcc3bee8db ***

test: commentary for [h-m]*.go

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5674112

Expand All Messages | Collapse All Messages