Issue 5674093: code review 5674093: go/printer, gofmt: improved comma placement

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5674093: code review 5674093: go/printer, gofmt: improved comma placement (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by gri

Modified:
12 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: improved comma placement Not a Go 1 issue, but appeared to be fairly easy to fix. - Note that a few existing test cases look slightly worse but those cases were not representative for real code. All real code looks better now. - Manual move of the comment in go/scanner/example_test.go before applying gofmt. - gofmt -w $GOROOT/src $GOROOT/misc Fixes issue 3062.

Patch Set 1 #

Patch Set 2 : diff -r f11edbb3cd95 https://code.google.com/p/go #

Patch Set 3 : diff -r f11edbb3cd95 https://code.google.com/p/go #

Patch Set 4 : diff -r 45c313581bc4 https://code.google.com/p/go #

Patch Set 5 : diff -r 45c313581bc4 https://code.google.com/p/go #

Patch Set 6 : diff -r 45c313581bc4 https://code.google.com/p/go #

Patch Set 7 : diff -r d83ad2b46bee https://code.google.com/p/go #

Patch Set 8 : diff -r 00981dfac864 https://code.google.com/p/go #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -27 lines)			Patch
M	src/pkg/crypto/tls/handshake_client.go	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_server.go	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/x509/x509.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/proxy/socks5.go	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/terminal/terminal.go	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1 2	6 chunks	+24 lines, -5 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.golden	View	1 2 3 4 5	4 chunks	+37 lines, -6 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.input	View	1	3 chunks	+29 lines, -2 lines	0 comments	Download
M	src/pkg/go/scanner/example_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2012-02-17 22:01:15 UTC) #1

gri

12 years, 2 months ago (2012-02-22 19:27:45 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=71e92f075ee7 ***

go/printer, gofmt: improved comma placement

Not a Go 1 issue, but appeared to be fairly easy to fix.

- Note that a few existing test cases look slightly worse but
  those cases were not representative for real code. All real
  code looks better now.

- Manual move of the comment in go/scanner/example_test.go
  before applying gofmt.

- gofmt -w $GOROOT/src $GOROOT/misc

Fixes issue 3062.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5674093

Expand All Messages | Collapse All Messages