Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(902)

Issue 5673079: code review 5673079: test: use testlib (fourth 100) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by rsc
Modified:
13 years, 1 month ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

test: use testlib (fourth 100) X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

Patch Set 1 #

Patch Set 2 : diff -r b984f2b4aa91 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b984f2b4aa91 https://code.google.com/p/go/ #

Patch Set 4 : diff -r f25acee8fc0c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -99 lines) Patch
M test/fixedbugs/bug397.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug398.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug402.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug403.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug405.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug410.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug411.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug412.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug413.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug416.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug418.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/float_lit.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/floatcmp.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/for.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/func.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/func1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/func3.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/func4.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/func5.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/func6.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/func7.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/func8.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/gc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/gc1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/gc2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/goto.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/hashmap.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/if.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/import.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/import1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/import5.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/indirect1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/init.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/init1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/initcomma.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/initialize.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/initializerr.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/initsyscall.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/int_lit.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/intcvt.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/bigdata.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/convert.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/convert1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/convert2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/embed.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/embed2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/explicit.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/fail.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/fake.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/pointer.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/receiver.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/receiver1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/returntype.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/iota.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/array.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/chan.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/chan1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/complit.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/convert.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/cplx1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/cplx2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/cplx3.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/cplx4.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/cplx5.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/divconst.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/divmod.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/embed.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/for.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/interbasic.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/interfun.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/intervar.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/label.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/litfun.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/mfunc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/modconst.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/ptrfun.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/ptrvar.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/range.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/rob1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/rob2.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/robfor.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/robfunc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/shift.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/simparray.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/simpbool.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/simpconv.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/simpfun.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/simpswitch.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/simpvar.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/slicearray.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/sliceslice.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/ken/strvar.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/label.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/label1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/literal.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/malloc1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mallocfin.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mallocrand.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mallocrep.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 1 month ago (2012-02-17 04:40:58 UTC) #1
bradfitz
LGTM On Fri, Feb 17, 2012 at 3:40 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 1 month ago (2012-02-17 04:44:09 UTC) #2
rsc
13 years, 1 month ago (2012-02-17 04:50:41 UTC) #3
*** Submitted as 62de2eb15696 ***

test: use testlib (fourth 100)

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5673079
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b