Issue 5667045: code review 5667045: cmd/dist: xprintf() can't output whole of 'dist env'.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5667045: code review 5667045: cmd/dist: xprintf() can't output whole of 'dist env'. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by mattn

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev_googlecode.com, mpimenov, brainman, golang-dev

Visibility:
Public.

Description

cmd/dist: xprintf() can't output whole of 'dist env'.

Patch Set 2 : diff -r 3e8fa8fa333f http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3e8fa8fa333f http://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 3e8fa8fa333f http://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	src/cmd/dist/windows.c	View	1 2 3	1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-14 10:58:23 UTC) #1

mpimenov

http://codereview.appspot.com/5667045/diff/3001/src/cmd/dist/windows.c File src/cmd/dist/windows.c (right): http://codereview.appspot.com/5667045/diff/3001/src/cmd/dist/windows.c#newcode837 src/cmd/dist/windows.c:837: DWORD n, w = 0; Please separate declaration and ...

12 years, 2 months ago (2012-02-14 11:03:19 UTC) #2

mattn

also fixed one more problem in my code. http://codereview.appspot.com/5667045/diff/3001/src/cmd/dist/windows.c File src/cmd/dist/windows.c (right): http://codereview.appspot.com/5667045/diff/3001/src/cmd/dist/windows.c#newcode837 src/cmd/dist/windows.c:837: DWORD ...

12 years, 2 months ago (2012-02-14 11:25:35 UTC) #3

mattn

ping probably, some users is getting fail to build on windows. My $PATH is greater ...

12 years, 2 months ago (2012-02-15 02:55:08 UTC) #4

brainman

12 years, 2 months ago (2012-02-15 03:25:33 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=348bbad57cab ***

cmd/dist: xprintf() can't output whole of 'dist env'.

R=golang-dev, mpimenov, alex.brainman
CC=golang-dev
http://codereview.appspot.com/5667045

Committer: Alex Brainman <alex.brainman@gmail.com>

Expand All Messages | Collapse All Messages