Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1106)

Issue 5662043: code review 5662043: gc: delete old unsafe functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by rsc
Modified:
13 years, 1 month ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: delete old unsafe functions Also update build to be able to run mkbuiltin again. The export form has changed a little, so builtin.c has more diffs than unsafe.go. In CL 5650069, I just edited the documentation, a rarely successful method of change.

Patch Set 1 #

Patch Set 2 : diff -r ce731433bb46 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4e8c247759c1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -85 lines) Patch
M src/cmd/dist/build.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/builtin.c View 1 3 chunks +60 lines, -65 lines 0 comments Download
M src/cmd/gc/mkbuiltin View 1 1 chunk +7 lines, -6 lines 0 comments Download
M src/cmd/gc/mkbuiltin1.c View 1 5 chunks +24 lines, -8 lines 0 comments Download
M src/cmd/gc/unsafe.go View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 1 month ago (2012-02-13 20:37:33 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=031625aa9500 *** gc: delete old unsafe functions Also update build to be ...
13 years, 1 month ago (2012-02-13 20:37:38 UTC) #2
ken3
13 years, 1 month ago (2012-02-13 22:44:49 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b