code review 5656083: test: use testlib (third 100)

test: use testlib (third 100)

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

[rsc, 2012-02-17 04:40:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitzgoog, 2012-02-17 04:44:13]

LGTM

On Fri, Feb 17, 2012 at 3:40 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test: use testlib (third 100)
>
> X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
> X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
> X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
> X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g
>
> Please review this at
http://codereview.appspot.com/**5656083/<http://codereview.appspot.com/5656083/>
>
> Affected files:
>  M test/fixedbugs/bug235.go
>  M test/fixedbugs/bug236.go
>  M test/fixedbugs/bug237.go
>  M test/fixedbugs/bug238.go
>  M test/fixedbugs/bug240.go
>  M test/fixedbugs/bug241.go
>  M test/fixedbugs/bug243.go
>  M test/fixedbugs/bug244.go
>  M test/fixedbugs/bug249.go
>  M test/fixedbugs/bug251.go
>  M test/fixedbugs/bug252.go
>  M test/fixedbugs/bug255.go
>  M test/fixedbugs/bug256.go
>  M test/fixedbugs/bug258.go
>  M test/fixedbugs/bug259.go
>  M test/fixedbugs/bug261.go
>  M test/fixedbugs/bug262.go
>  M test/fixedbugs/bug263.go
>  M test/fixedbugs/bug269.go
>  M test/fixedbugs/bug271.go
>  M test/fixedbugs/bug272.go
>  M test/fixedbugs/bug273.go
>  M test/fixedbugs/bug274.go
>  M test/fixedbugs/bug278.go
>  M test/fixedbugs/bug279.go
>  M test/fixedbugs/bug280.go
>  M test/fixedbugs/bug281.go
>  M test/fixedbugs/bug284.go
>  M test/fixedbugs/bug287.go
>  M test/fixedbugs/bug288.go
>  M test/fixedbugs/bug289.go
>  M test/fixedbugs/bug290.go
>  M test/fixedbugs/bug291.go
>  M test/fixedbugs/bug292.go
>  M test/fixedbugs/bug293.go
>  M test/fixedbugs/bug294.go
>  M test/fixedbugs/bug295.go
>  M test/fixedbugs/bug296.go
>  M test/fixedbugs/bug297.go
>  M test/fixedbugs/bug298.go
>  M test/fixedbugs/bug299.go
>  M test/fixedbugs/bug300.go
>  M test/fixedbugs/bug303.go
>  M test/fixedbugs/bug304.go
>  M test/fixedbugs/bug305.go
>  M test/fixedbugs/bug307.go
>  M test/fixedbugs/bug308.go
>  M test/fixedbugs/bug309.go
>  M test/fixedbugs/bug311.go
>  M test/fixedbugs/bug312.go
>  M test/fixedbugs/bug318.go
>  M test/fixedbugs/bug319.go
>  M test/fixedbugs/bug320.go
>  M test/fixedbugs/bug323.go
>  M test/fixedbugs/bug325.go
>  M test/fixedbugs/bug326.go
>  M test/fixedbugs/bug327.go
>  M test/fixedbugs/bug329.go
>  M test/fixedbugs/bug330.go
>  M test/fixedbugs/bug332.go
>  M test/fixedbugs/bug333.go
>  M test/fixedbugs/bug336.go
>  M test/fixedbugs/bug337.go
>  M test/fixedbugs/bug338.go
>  M test/fixedbugs/bug339.go
>  M test/fixedbugs/bug340.go
>  M test/fixedbugs/bug342.go
>  M test/fixedbugs/bug344.go
>  M test/fixedbugs/bug347.go
>  M test/fixedbugs/bug348.go
>  M test/fixedbugs/bug349.go
>  M test/fixedbugs/bug350.go
>  M test/fixedbugs/bug351.go
>  M test/fixedbugs/bug353.go
>  M test/fixedbugs/bug355.go
>  M test/fixedbugs/bug357.go
>  M test/fixedbugs/bug358.go
>  M test/fixedbugs/bug362.go
>  M test/fixedbugs/bug363.go
>  M test/fixedbugs/bug364.go
>  M test/fixedbugs/bug365.go
>  M test/fixedbugs/bug366.go
>  M test/fixedbugs/bug368.go
>  M test/fixedbugs/bug369.go
>  M test/fixedbugs/bug370.go
>  M test/fixedbugs/bug371.go
>  M test/fixedbugs/bug373.go
>  M test/fixedbugs/bug374.go
>  M test/fixedbugs/bug376.go
>  M test/fixedbugs/bug379.go
>  M test/fixedbugs/bug380.go
>  M test/fixedbugs/bug381.go
>  M test/fixedbugs/bug383.go
>  M test/fixedbugs/bug384.go
>  M test/fixedbugs/bug386.go
>  M test/fixedbugs/bug388.go
>  M test/fixedbugs/bug389.go
>  M test/fixedbugs/bug390.go
>  M test/fixedbugs/bug394.go
>
>
>

[rsc, 2012-02-17 04:50:02]

*** Submitted as f25acee8fc0c ***

test: use testlib (third 100)

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5656083