code review 5656082: test: use testlib (first 100)

test: use testlib (first 100)

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

[rsc, 2012-02-17 04:39:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-02-17 04:43:17]

Do you want to distinguish "link" from "build" & "run"?  I ended up doing
that.

Or will build always mean link?


On Fri, Feb 17, 2012 at 3:39 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test: use testlib (first 100)
>
> X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
> X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
> X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
> X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g
>
> Please review this at
http://codereview.appspot.com/**5656082/<http://codereview.appspot.com/5656082/>
>
> Affected files:
>  M test/235.go
>  M test/alias.go
>  M test/alias1.go
>  M test/append.go
>  M test/assign.go
>  M test/assign1.go
>  M test/bench/garbage/peano.go
>  M test/bigalg.go
>  M test/bigmap.go
>  M test/blank.go
>  M test/blank1.go
>  M test/chan/doubleselect.go
>  M test/chan/fifo.go
>  M test/chan/goroutines.go
>  M test/chan/nonblock.go
>  M test/chan/perm.go
>  M test/chan/powser1.go
>  M test/chan/powser2.go
>  M test/chan/select.go
>  M test/chan/select2.go
>  M test/chan/select3.go
>  M test/chan/select4.go
>  M test/chan/select6.go
>  M test/chan/select7.go
>  M test/chan/sendstmt.go
>  M test/chan/sieve1.go
>  M test/chan/sieve2.go
>  M test/chan/zerosize.go
>  M test/chancap.go
>  M test/char_lit1.go
>  M test/closedchan.go
>  M test/closure.go
>  M test/cmp.go
>  M test/cmp6.go
>  M test/cmplx.go
>  M test/complit.go
>  M test/complit1.go
>  M test/const.go
>  M test/const1.go
>  M test/const2.go
>  M test/const3.go
>  M test/convert.go
>  M test/convert1.go
>  M test/convert3.go
>  M test/convlit.go
>  M test/convlit1.go
>  M test/copy.go
>  M test/ddd.go
>  M test/ddd1.go
>  M test/decl.go
>  M test/declbad.go
>  M test/defer.go
>  M test/divide.go
>  M test/dwarf/linedirectives.go
>  M test/empty.go
>  M test/env.go
>  M test/eof.go
>  M test/eof1.go
>  M test/escape.go
>  M test/escape3.go
>  M test/fixedbugs/bug000.go
>  M test/fixedbugs/bug002.go
>  M test/fixedbugs/bug003.go
>  M test/fixedbugs/bug004.go
>  M test/fixedbugs/bug005.go
>  M test/fixedbugs/bug006.go
>  M test/fixedbugs/bug007.go
>  M test/fixedbugs/bug008.go
>  M test/fixedbugs/bug009.go
>  M test/fixedbugs/bug010.go
>  M test/fixedbugs/bug011.go
>  M test/fixedbugs/bug012.go
>  M test/fixedbugs/bug013.go
>  M test/fixedbugs/bug014.go
>  M test/fixedbugs/bug015.go
>  M test/fixedbugs/bug016.go
>  M test/fixedbugs/bug017.go
>  M test/fixedbugs/bug021.go
>  M test/fixedbugs/bug022.go
>  M test/fixedbugs/bug023.go
>  M test/fixedbugs/bug024.go
>  M test/fixedbugs/bug026.go
>  M test/fixedbugs/bug027.go
>  M test/fixedbugs/bug028.go
>  M test/fixedbugs/bug030.go
>  M test/fixedbugs/bug031.go
>  M test/fixedbugs/bug035.go
>  M test/fixedbugs/bug037.go
>  M test/fixedbugs/bug039.go
>  M test/fixedbugs/bug045.go
>  M test/fixedbugs/bug046.go
>  M test/fixedbugs/bug047.go
>  M test/fixedbugs/bug048.go
>  M test/fixedbugs/bug049.go
>  M test/fixedbugs/bug050.go
>  M test/fixedbugs/bug051.go
>  M test/fixedbugs/bug052.go
>  M test/fixedbugs/bug053.go
>  M test/fixedbugs/bug054.go
>
>
>

[bradfitz, 2012-02-17 04:44:03]

LGTM

On Fri, Feb 17, 2012 at 3:43 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Do you want to distinguish "link" from "build" & "run"?  I ended up doing
> that.
>
> Or will build always mean link?
>
>
> On Fri, Feb 17, 2012 at 3:39 PM, <rsc@golang.org> wrote:
>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go/
>>
>>
>> Description:
>> test: use testlib (first 100)
>>
>> X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
>> X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
>> X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
>> X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g
>>
>> Please review this at
http://codereview.appspot.com/**5656082/<http://codereview.appspot.com/5656082/>
>>
>> Affected files:
>>  M test/235.go
>>  M test/alias.go
>>  M test/alias1.go
>>  M test/append.go
>>  M test/assign.go
>>  M test/assign1.go
>>  M test/bench/garbage/peano.go
>>  M test/bigalg.go
>>  M test/bigmap.go
>>  M test/blank.go
>>  M test/blank1.go
>>  M test/chan/doubleselect.go
>>  M test/chan/fifo.go
>>  M test/chan/goroutines.go
>>  M test/chan/nonblock.go
>>  M test/chan/perm.go
>>  M test/chan/powser1.go
>>  M test/chan/powser2.go
>>  M test/chan/select.go
>>  M test/chan/select2.go
>>  M test/chan/select3.go
>>  M test/chan/select4.go
>>  M test/chan/select6.go
>>  M test/chan/select7.go
>>  M test/chan/sendstmt.go
>>  M test/chan/sieve1.go
>>  M test/chan/sieve2.go
>>  M test/chan/zerosize.go
>>  M test/chancap.go
>>  M test/char_lit1.go
>>  M test/closedchan.go
>>  M test/closure.go
>>  M test/cmp.go
>>  M test/cmp6.go
>>  M test/cmplx.go
>>  M test/complit.go
>>  M test/complit1.go
>>  M test/const.go
>>  M test/const1.go
>>  M test/const2.go
>>  M test/const3.go
>>  M test/convert.go
>>  M test/convert1.go
>>  M test/convert3.go
>>  M test/convlit.go
>>  M test/convlit1.go
>>  M test/copy.go
>>  M test/ddd.go
>>  M test/ddd1.go
>>  M test/decl.go
>>  M test/declbad.go
>>  M test/defer.go
>>  M test/divide.go
>>  M test/dwarf/linedirectives.go
>>  M test/empty.go
>>  M test/env.go
>>  M test/eof.go
>>  M test/eof1.go
>>  M test/escape.go
>>  M test/escape3.go
>>  M test/fixedbugs/bug000.go
>>  M test/fixedbugs/bug002.go
>>  M test/fixedbugs/bug003.go
>>  M test/fixedbugs/bug004.go
>>  M test/fixedbugs/bug005.go
>>  M test/fixedbugs/bug006.go
>>  M test/fixedbugs/bug007.go
>>  M test/fixedbugs/bug008.go
>>  M test/fixedbugs/bug009.go
>>  M test/fixedbugs/bug010.go
>>  M test/fixedbugs/bug011.go
>>  M test/fixedbugs/bug012.go
>>  M test/fixedbugs/bug013.go
>>  M test/fixedbugs/bug014.go
>>  M test/fixedbugs/bug015.go
>>  M test/fixedbugs/bug016.go
>>  M test/fixedbugs/bug017.go
>>  M test/fixedbugs/bug021.go
>>  M test/fixedbugs/bug022.go
>>  M test/fixedbugs/bug023.go
>>  M test/fixedbugs/bug024.go
>>  M test/fixedbugs/bug026.go
>>  M test/fixedbugs/bug027.go
>>  M test/fixedbugs/bug028.go
>>  M test/fixedbugs/bug030.go
>>  M test/fixedbugs/bug031.go
>>  M test/fixedbugs/bug035.go
>>  M test/fixedbugs/bug037.go
>>  M test/fixedbugs/bug039.go
>>  M test/fixedbugs/bug045.go
>>  M test/fixedbugs/bug046.go
>>  M test/fixedbugs/bug047.go
>>  M test/fixedbugs/bug048.go
>>  M test/fixedbugs/bug049.go
>>  M test/fixedbugs/bug050.go
>>  M test/fixedbugs/bug051.go
>>  M test/fixedbugs/bug052.go
>>  M test/fixedbugs/bug053.go
>>  M test/fixedbugs/bug054.go
>>
>>
>>
>

[rsc, 2012-02-17 04:49:00]

*** Submitted as ecdd4b70e5ab ***

test: use testlib (first 100)

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5656082

[rsc, 2012-02-17 04:49:32]

On Thu, Feb 16, 2012 at 23:43, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Do you want to distinguish "link" from "build" & "run"?  I ended up doing
> that.

Assume you noticed, but just in case, yes:

compile = 6g
build = 6g + 6l
run = 6g + 6l + 6.out

[bradfitz, 2012-02-17 04:50:54]

On Fri, Feb 17, 2012 at 3:49 PM, Russ Cox <rsc@golang.org> wrote:

> On Thu, Feb 16, 2012 at 23:43, Brad Fitzpatrick <bradfitz@golang.org>
> wrote:
> > Do you want to distinguish "link" from "build" & "run"?  I ended up doing
> > that.
>
> Assume you noticed, but just in case, yes:
>
> compile = 6g
> build = 6g + 6l
> run = 6g + 6l + 6.out
>

ah, cool. I'd mentally merged compile & build into what I previous called
"build" (your "compile").