Issue 5655045: code review 5655045: os: delete Exec, NewFile takes uintpr, rename ShellExpa...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5655045: code review 5655045: os: delete Exec, NewFile takes uintpr, rename ShellExpa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by bradfitz

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

os: delete Exec, NewFile takes uintptr, rename ShellExpand, doc fixes Delete O_NDELAY, O_NONBLOCK, O_NOCTTY, O_ASYNC. Clean up some docs. Rename ShellExpand -> ExpandEnv. Make NewFile take a uintptr; change File.Fd to return one. (for API compatibility between Unix and Windows) Fixes issue 2947

Patch Set 1 #

Patch Set 2 : diff -r 89bf6c7e5674 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r 58e600a849f2 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -95 lines)			Patch
M	doc/go1.html	View	1 2	1 chunk	+13 lines, -4 lines	0 comments	Download
M	doc/go1.tmpl	View	1 2	1 chunk	+13 lines, -4 lines	0 comments	Download
M	src/pkg/net/fd.go	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/net/file.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/newpollserver.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/sendfile_linux.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/env.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/os/error_posix.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/os/exec/exec_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/exec_plan9.go	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/pkg/os/exec_posix.go	View	1	2 chunks	+1 line, -20 lines	0 comments	Download
M	src/pkg/os/file.go	View	1	1 chunk	+11 lines, -15 lines	0 comments	Download
M	src/pkg/os/file_unix.go	View	1	4 chunks	+9 lines, -12 lines	0 comments	Download
M	src/pkg/os/file_windows.go	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download
M	src/pkg/os/stat_windows.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-02-10 02:21:00 UTC) #1

LGTM after fixing doc http://codereview.appspot.com/5655045/diff/3/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5655045/diff/3/doc/go1.tmpl#newcode1265 doc/go1.tmpl:1265: <p>The <code>NewFile</code> function now takes ...

13 years, 1 month ago (2012-02-10 02:49:25 UTC) #2

bradfitz

13 years, 1 month ago (2012-02-10 03:16:20 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d39a981f1883 ***

os: delete Exec, NewFile takes uintptr, rename ShellExpand, doc fixes

Delete O_NDELAY, O_NONBLOCK, O_NOCTTY, O_ASYNC.

Clean up some docs.

Rename ShellExpand -> ExpandEnv.

Make NewFile take a uintptr; change File.Fd to return one.
(for API compatibility between Unix and Windows)

Fixes issue 2947

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5655045

Expand All Messages | Collapse All Messages