Issue 5651079: code review 5651079: gc, 8g, 8l: fix a handful of warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5651079: code review 5651079: gc, 8g, 8l: fix a handful of warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by ality

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gc, 8g, 8l: fix a handful of warnings 8g/cgen.c print format type mismatch 8l/asm.c resoff set and not used gc/pgen.c misleading comparison INT > 0x80000000 gc/reflect.c dalgsym must be static to match forward declaration gc/subr.c assumed_equal set and not used hashmem's second argument is not used gc/walk.c duplicated (unreachable) code

Patch Set 1 #

Patch Set 2 : diff -r 7e665c5da059 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7e665c5da059 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4fb39381b140 https://code.google.com/p/go/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -12 lines)			Patch
M	src/cmd/8g/cgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8l/asm.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/pgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/reflect.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/subr.c	View	1	4 chunks	+3 lines, -5 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 1 month ago (2012-02-12 01:55:23 UTC) #1

ality

13 years, 1 month ago (2012-02-13 07:07:35 UTC) #3

*** Submitted as 78d9bba0ab24 ***

gc, 8g, 8l: fix a handful of warnings

8g/cgen.c
        print format type mismatch

8l/asm.c
        resoff set and not used

gc/pgen.c
        misleading comparison INT > 0x80000000

gc/reflect.c
        dalgsym must be static to match forward declaration

gc/subr.c
        assumed_equal set and not used
        hashmem's second argument is not used

gc/walk.c
        duplicated (unreachable) code

R=rsc
CC=golang-dev
http://codereview.appspot.com/5651079

Expand All Messages | Collapse All Messages