Issue 5648044: code review 5648044: net: enable SO_REUSEADDR, SO_REUSEPORT options on strea...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5648044: code review 5648044: net: enable SO_REUSEADDR, SO_REUSEPORT options on strea... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by mikio

Modified:
13 years, 1 month ago

Reviewers:
frichter

CC:
rsc, jsing, golang-dev

Visibility:
Public.

Description

net: enable SO_REUSEADDR, SO_REUSEPORT options on stream, multicast listeners only This CL changes default SOL_SOCKET settings to mitigate connect failure on OpenBSD or similar platforms which support randomized transport protocol port number assignment. Fixes issue 2830.

Patch Set 1 : diff -r 838fa1514da3 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 0a9db0958a5e https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -33 lines)			Patch
M	src/pkg/net/sock_bsd.go	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/net/sock_linux.go	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/net/sock_windows.go	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/net/sockopt_bsd.go	View	1 chunk	+16 lines, -19 lines	0 comments	Download
M	src/pkg/net/sockopt_linux.go	View	1 chunk	+8 lines, -11 lines	0 comments	Download
M	src/pkg/net/sockopt_windows.go	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello rsc@golang.org, jsing@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-02-09 10:09:22 UTC) #1

mikio

*** Submitted as http://code.google.com/p/go/source/detail?r=e975fac3133f *** net: enable SO_REUSEADDR, SO_REUSEPORT options on stream, multicast listeners only ...

13 years, 1 month ago (2012-02-11 02:50:56 UTC) #3

frichter

I'm seeing this building on Win32: pkg\net\sock_windows.go:23: not enough arguments in call to setDefaultListenerSockopts But ...

13 years, 1 month ago (2012-02-11 06:53:07 UTC) #4

mikio

13 years, 1 month ago (2012-02-11 07:13:38 UTC) #5

On Sat, Feb 11, 2012 at 3:53 PM, Fred Richter <hcwfrichter@gmail.com> wrote:

> But the Windows builders don't seem to be reporting any issues. Anyone else
> see this error (which looks real enough)?

Thank you for the report, just submitted a fix CL.

Expand All Messages | Collapse All Messages