Issue 5643062: code review 5643062: spec: send on closed channel counts as "proceeding"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5643062: code review 5643062: spec: send on closed channel counts as "proceeding" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by rsc

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, gri, r

Visibility:
Public.

Description

spec: send on closed channel counts as "proceeding" Other wordings are possible but defining this as one of the ways to proceed means we don't have to add language about this to the description of select. Fixes issue 2825.

Patch Set 1 #

Patch Set 2 : diff -r 13cd383941ad https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 13cd383941ad https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r c698cbeae602 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	doc/go_spec.html	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-02-08 18:14:18 UTC) #1

gri

LGTM http://codereview.appspot.com/5643062/diff/4/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5643062/diff/4/doc/go_spec.html#newcode3 doc/go_spec.html:3: "Subtitle": "Version of February 6, 2012" s/6/8/

13 years, 1 month ago (2012-02-08 18:17:20 UTC) #2

rsc

13 years, 1 month ago (2012-02-08 20:24:52 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=3cddb7bc397c ***

spec: send on closed channel counts as "proceeding"

Other wordings are possible but defining this as one
of the ways to proceed means we don't have to add
language about this to the description of select.

Fixes issue 2825.

R=golang-dev, gri, r
CC=golang-dev
http://codereview.appspot.com/5643062

Expand All Messages | Collapse All Messages