Issue 5642064: code review 5642064: runtime: fix "SysReserve returned unaligned address" bu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5642064: code review 5642064: runtime: fix "SysReserve returned unaligned address" bu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by minux1

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: fix "SysReserve returned unaligned address" bug on 32-bit systems

Patch Set 2 : diff -r 36c9c7810f14 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 36c9c7810f14 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/malloc.goc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-02-08 21:38:58 UTC) #1

rsc

Thanks; please move the p = nil down into the code section. This is an ...

13 years, 1 month ago (2012-02-08 21:40:43 UTC) #2

minux1

This CL fixed the recent linux/386 and linux/arm build breakage. http://build.golang.org/log/9da48323cb07fb5401de83dcc294013725db4303 http://build.golang.org/log/1d05f134ff397362df788ea1db65e63fc7f3c402

13 years, 1 month ago (2012-02-08 21:42:49 UTC) #3

minux1

done. PTAL. On Thu, Feb 9, 2012 at 5:40 AM, Russ Cox <rsc@golang.org> wrote: > ...

13 years, 1 month ago (2012-02-08 21:45:10 UTC) #4

nigeltao

13 years, 1 month ago (2012-02-08 22:25:18 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=1f2a839158ce ***

runtime: fix "SysReserve returned unaligned address" bug on 32-bit systems

R=rsc
CC=golang-dev
http://codereview.appspot.com/5642064

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages