code review 56410043: go.tools/dashboard/app: show sub-repository build history

go.tools/dashboard/app: show sub-repository build history

[adg, 2014-01-24 03:46:57]

Hello adonovan (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[adg, 2014-01-24 03:47:38]

http://build-test.golang.org/
http://build-test.golang.org/?repo=code.google.com%2fp%2fgo.tools

[adonovan, 2014-01-24 04:52:15]

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/build.go
File dashboard/app/build/build.go (right):

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/build...
dashboard/app/build/build.go:180: p := strings.SplitN(r, "|", 4)
Add a comment explaining the columns?

[gobot, 2014-01-28 01:37:13]

R=cmang@golang.org (assigned by adg@golang.org)

[cmang, 2014-01-28 02:52:42]

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/ui.go
File dashboard/app/build/ui.go (right):

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/ui.go...
dashboard/app/build/ui.go:56: pkg := &Package{} // empty package is the main Go
tree
s/Go/repository, keeping Gccgo and future compilers in mind.

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/ui.html
File dashboard/app/build/ui.html (right):

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/ui.ht...
dashboard/app/build/ui.html:110: <th class="result arch">go</th>
s/go/{{$.Dashboard.Name}}

[adg, 2014-01-28 03:10:37]

PTAL

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/build.go
File dashboard/app/build/build.go (right):

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/build...
dashboard/app/build/build.go:180: p := strings.SplitN(r, "|", 4)
On 2014/01/24 04:52:15, adonovan wrote:
> Add a comment explaining the columns?

partsToHash documents it below, I guess.
This could be better in general. I'm inclined to leave as-is for now.

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/ui.go
File dashboard/app/build/ui.go (right):

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/ui.go...
dashboard/app/build/ui.go:56: pkg := &Package{} // empty package is the main Go
tree
On 2014/01/28 02:52:43, cmang wrote:
> s/Go/repository, keeping Gccgo and future compilers in mind.

Done.

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/ui.html
File dashboard/app/build/ui.html (right):

https://codereview.appspot.com/56410043/diff/120001/dashboard/app/build/ui.ht...
dashboard/app/build/ui.html:110: <th class="result arch">go</th>
On 2014/01/28 02:52:43, cmang wrote:
> s/go/{{$.Dashboard.Name}}

Done.

[cmang, 2014-01-28 03:18:15]

LGTM.

[adg, 2014-01-28 03:30:59]

*** Submitted as
https://code.google.com/p/go/source/detail?r=910bb3c340c1&repo=tools ***

go.tools/dashboard/app: show sub-repository build history

LGTM=cmang
R=adonovan, gobot, cmang
CC=golang-codereviews
https://codereview.appspot.com/56410043