Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3619)

Issue 5634046: code review 5634046: go_spec: primality is elusive (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by r
Modified:
10 years ago
Reviewers:
aml, rsc, mtj1, aam
CC:
golang-dev, rsc
Visibility:
Public.

Description

go_spec: primality is elusive This time for sure.

Patch Set 1 #

Patch Set 2 : diff -r 24ea565d3631 https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M doc/go_spec.html View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2012-02-06 11:45:26 UTC) #1
rsc
LGTM if you really want to get mail about this, make 1 prime.
12 years, 1 month ago (2012-02-06 16:01:35 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=c90b59861968 *** go_spec: primality is elusive This time for sure. R=golang-dev, rsc ...
12 years, 1 month ago (2012-02-06 19:59:43 UTC) #3
aml
https://codereview.appspot.com/5634046/diff/3001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/5634046/diff/3001/doc/go_spec.html#newcode2146 doc/go_spec.html:2146: primes := []int{2, 3, 5, 7, 9, 2147483647} 9 ...
10 years ago (2014-03-20 11:21:06 UTC) #4
mtj1
Ouch! The next line is questionable too... vowels := [128]bool{'a': true, 'e': true, 'i': true, ...
10 years ago (2014-03-20 15:00:22 UTC) #5
aml
Disclaimer. I'm not a grammarian, and even not a native English speaker. But from the ...
10 years ago (2014-03-20 15:10:44 UTC) #6
aam
10 years ago (2014-03-20 15:19:05 UTC) #7
I liked 9. I also liked "9 is a prime if it's a hot day".

https://codereview.appspot.com/5630043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b