Issue 5629052: code review 5629052: cmd/dist: fix arm build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5629052: code review 5629052: cmd/dist: fix arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by rsc

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

cmd/dist: fix arm build 5l does not use the whole set of ld files like the other linkers do.

Patch Set 1 #

Patch Set 2 : diff -r 830d67171f60 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 830d67171f60 https://code.google.com/p/go/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/cmd/dist/build.c	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 1 month ago (2012-02-04 07:01:57 UTC) #1

rsc

13 years, 1 month ago (2012-02-04 07:02:01 UTC) #2

*** Submitted as 33b81249a41c ***

cmd/dist: fix arm build

5l does not use the whole set of ld files
like the other linkers do.

TBR=golang-dev
CC=golang-dev
http://codereview.appspot.com/5629052

Expand All Messages | Collapse All Messages