code review 5615058: build: use cmd/dist

build: use cmd/dist

[rsc, 2012-02-03 07:49:09]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-03 08:42:47]

http://codereview.appspot.com/5615058/diff/3/src/make.bash
File src/make.bash (right):

http://codereview.appspot.com/5615058/diff/3/src/make.bash#newcode12
src/make.bash:12: # Test for bad ld.
Why is this in make.bash and in dist?

$ grep gold *.c
build.c:	if(contains(bstr(&b), "gold") && contains(bstr(&b), " 2.20")) {
build.c:		fatal("Your system has gold 2.20 installed.\n"
build.c:			"Run sudo apt-get remove binutils-gold.");

http://codereview.appspot.com/5615058/diff/3/src/make.bash#newcode60
src/make.bash:60: ../bin/tool/dist installed
isn't this done in all.bash too? oh, or that just sources this.

[ality, 2012-02-03 08:55:32]

bradfitz@golang.org once said:
> http://codereview.appspot.com/5615058/diff/3/src/make.bash#newcode12
> src/make.bash:12: # Test for bad ld.
> Why is this in make.bash and in dist?
> 
> $ grep gold *.c
> build.c:	if(contains(bstr(&b), "gold") && contains(bstr(&b), " 2.20")) {
> build.c:		fatal("Your system has gold 2.20 installed.\n"
> build.c:			"Run sudo apt-get remove binutils-gold.");

This check will be removed from dist in CL 5622058.

  Anthony

[rsc, 2012-02-03 14:43:21]

On Fri, Feb 3, 2012 at 03:42,  <bradfitz@golang.org> wrote:
> isn't this done in all.bash too? oh, or that just sources this.

Yes.  I should add a flag to avoid printing the
'installed' message twice; that's not what's
in the shell scripts right now.  It prints the message
both at the end of make.bash (in case that's all
you're running) and at the end of all.bash.

Russ

[bradfitz, 2012-02-03 18:14:29]

LGTM

[r, 2012-02-03 19:18:02]

LGTM
raising a related question: s/go_bootstrap/bootstrap/?

[rsc, 2012-02-03 19:38:08]

On Fri, Feb 3, 2012 at 14:18,  <r@golang.org> wrote:
> raising a related question: s/go_bootstrap/bootstrap/

maybe, but maybe not.  it doesn't last beyond the build,
and it helps to know that it is the go tool, just in bootstrap form.

[r2, 2012-02-03 19:39:35]

On 04/02/2012, at 6:38 AM, Russ Cox wrote:

> On Fri, Feb 3, 2012 at 14:18,  <r@golang.org> wrote:
>> raising a related question: s/go_bootstrap/bootstrap/
> 
> maybe, but maybe not.  it doesn't last beyond the build,
> and it helps to know that it is the go tool, just in bootstrap form.


stet is fine. just asking.

-rob

[rsc, 2012-02-03 20:21:44]

PTAL

A few deltas since patch set 3, all trivial.

[rsc, 2012-02-03 20:22:00]

(Oh, and this actually runs all.bash to completion now.)

[bradfitz, 2012-02-03 20:26:10]

LGTM

"banner" is a much nicer named than "installed", too.


On Fri, Feb 3, 2012 at 12:21 PM, Russ Cox <rsc@golang.org> wrote:

> (Oh, and this actually runs all.bash to completion now.)
>

[bradfitz, 2012-02-03 20:26:45]

LGTM

"banner" is a much nicer named than "installed", too.


On Fri, Feb 3, 2012 at 12:21 PM, Russ Cox <rsc@golang.org> wrote:

> (Oh, and this actually runs all.bash to completion now.)
>

[r, 2012-02-03 21:08:56]

LGTM

[iant, 2012-02-03 22:09:48]

LGTM

[mikio, 2012-02-04 02:54:45]

LGTM

Please include tweaked (s/env.bash/run.bash/g) src/clean.bash too.

[rsc, 2012-02-04 05:54:13]

*** Submitted as 7f226247c3b0 ***

build: use cmd/dist

R=bradfitz, ality, r, r, iant, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/5615058