Issue 5615056: code review 5615056: weekly.2012-02-07

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5615056: code review 5615056: weekly.2012-02-07 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by adg

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, dsymonds, r

Visibility:
Public.

Patch Set 2 : diff -r 062ed4b8b8de https://go.googlecode.com/hg #

Total comments: 4

Patch Set 3 : diff -r 1ca43e8ce166 https://go.googlecode.com/hg #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -1 line)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/weekly.html	View	1 2	1 chunk	+190 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 2 months ago (2012-02-03 05:10:30 UTC) #1

adg

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 2 months ago (2012-02-08 02:47:13 UTC) #3

LGTM http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html#newcode24 doc/devel/weekly.html:24: This puts the lesser-used tools (6g, cgo, govet, ...

12 years, 2 months ago (2012-02-08 03:29:16 UTC) #5

adg

12 years, 2 months ago (2012-02-08 03:37:53 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=52ba9506bd99 ***

weekly.2012-02-07

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5615056

http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html#newcode24
doc/devel/weekly.html:24: This puts the lesser-used tools (6g, cgo, govet, etc)
outside the user PATH.
On 2012/02/08 03:29:16, r wrote:
> s/etc/&./

Done.

http://codereview.appspot.com/5615056/diff/4001/doc/devel/weekly.html#newcode183
doc/devel/weekly.html:183: restore primality.
On 2012/02/08 03:29:16, r wrote:
> this accumulates to only one change, which is adding a prime number.

Done.

Expand All Messages | Collapse All Messages