Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1296)

Issue 5606056: code review 5606056: test: don't use package main for files without a main f... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by bradfitz
Modified:
13 years, 1 month ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

test: don't use package main for files without a main function Part of issue 2833, but works fine with current test runner.

Patch Set 1 #

Patch Set 2 : diff -r 01a81f0041cc https://go.googlecode.com/hg #

Patch Set 3 : diff -r 01a81f0041cc https://go.googlecode.com/hg #

Patch Set 4 : diff -r 2631a7b6fb8e https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M test/eof1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug063.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug066.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug071.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug109.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug118.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug150.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug151.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug219.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug232.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug233.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug235.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug250.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug267.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug283.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug309.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug354.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug393.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/interface/recursive.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/rune.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
13 years, 1 month ago (2012-02-02 23:24:40 UTC) #1
rsc
LGTM
13 years, 1 month ago (2012-02-02 23:29:53 UTC) #2
bradfitz
13 years, 1 month ago (2012-02-03 19:43:26 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=114d4a5394e0 ***

test: don't use package main for files without a main function

Part of issue 2833, but works fine with current test runner.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5606056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b