code review 56060043: undo CL 45770044 / d795425bfa18

undo CL 45770044 / d795425bfa18

Breaks darwin and freebsd.

««« original CL description
runtime: increase page size to 8K
Tcmalloc uses 8K, 32K and 64K pages, and in custom setups 256K pages.
Only Chromium uses 4K pages today (in "slow but small" configuration).
The general tendency is to increase page size, because it reduces
metadata size and DTLB pressure.
This change reduces GC pause by ~10% and slightly improves other metrics.

json-1
allocated                 8037492      8038689      +0.01%
allocs                     105762       105573      -0.18%
cputime                 158400000    155800000      -1.64%
gc-pause-one              4412234      4135702      -6.27%
gc-pause-total            2647340      2398707      -9.39%
rss                      54923264     54525952      -0.72%
sys-gc                    3952624      3928048      -0.62%
sys-heap                 46399488     46006272      -0.85%
sys-other                 5597504      5290304      -5.49%
sys-stack                  393216       393216      +0.00%
sys-total                56342832     55617840      -1.29%
time                    158478890    156046916      -1.53%
virtual-mem             256548864    256593920      +0.02%

garbage-1
allocated                 2991113      2986259      -0.16%
allocs                      62844        62652      -0.31%
cputime                  16330000     15860000      -2.88%
gc-pause-one            789108229    725555211      -8.05%
gc-pause-total            3945541      3627776      -8.05%
rss                    1143660544   1132253184      -1.00%
sys-gc                   65609600     65806208      +0.30%
sys-heap               1032388608   1035599872      +0.31%
sys-other                37501632     22777664     -39.26%
sys-stack                 8650752      8781824      +1.52%
sys-total              1144150592   1132965568      -0.98%
time                     16364602     15891994      -2.89%
virtual-mem            1327296512   1313746944      -1.02%

R=golang-codereviews, dave, khr, rsc, khr
CC=golang-codereviews
https://codereview.appspot.com/45770044
»»»

[dvyukov, 2014-01-23 15:56:40]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[minux1, 2014-01-23 15:57:56]

LGTM.

[dvyukov, 2014-01-23 15:58:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=75adcf310434 ***

undo CL 45770044 / d795425bfa18

Breaks darwin and freebsd.

««« original CL description
runtime: increase page size to 8K
Tcmalloc uses 8K, 32K and 64K pages, and in custom setups 256K pages.
Only Chromium uses 4K pages today (in "slow but small" configuration).
The general tendency is to increase page size, because it reduces
metadata size and DTLB pressure.
This change reduces GC pause by ~10% and slightly improves other metrics.

json-1
allocated                 8037492      8038689      +0.01%
allocs                     105762       105573      -0.18%
cputime                 158400000    155800000      -1.64%
gc-pause-one              4412234      4135702      -6.27%
gc-pause-total            2647340      2398707      -9.39%
rss                      54923264     54525952      -0.72%
sys-gc                    3952624      3928048      -0.62%
sys-heap                 46399488     46006272      -0.85%
sys-other                 5597504      5290304      -5.49%
sys-stack                  393216       393216      +0.00%
sys-total                56342832     55617840      -1.29%
time                    158478890    156046916      -1.53%
virtual-mem             256548864    256593920      +0.02%

garbage-1
allocated                 2991113      2986259      -0.16%
allocs                      62844        62652      -0.31%
cputime                  16330000     15860000      -2.88%
gc-pause-one            789108229    725555211      -8.05%
gc-pause-total            3945541      3627776      -8.05%
rss                    1143660544   1132253184      -1.00%
sys-gc                   65609600     65806208      +0.30%
sys-heap               1032388608   1035599872      +0.31%
sys-other                37501632     22777664     -39.26%
sys-stack                 8650752      8781824      +1.52%
sys-total              1144150592   1132965568      -0.98%
time                     16364602     15891994      -2.89%
virtual-mem            1327296512   1313746944      -1.02%

R=golang-codereviews, dave, khr, rsc, khr
CC=golang-codereviews
https://codereview.appspot.com/45770044
»»»

R=golang-codereviews
CC=golang-codereviews
https://codereview.appspot.com/56060043

[dvyukov, 2014-01-23 15:59:19]

but the performance improvements were juicy...

garbage-1                 old          new      delta
sys-other            37763776     21720896     -42.48

garbage-8                 old          new      delta
sys-other            40499904     23613248     -41.70

http-1                    old          new      delta
sys-other             5269824      4995392      -5.21

http-8                    old          new      delta
sys-other             5552448      5265728      -5.16

rpc-1                     old          new      delta
gc-pause-one          5836044      5131415     -12.07
gc-pause-total            478          420     -12.13
sys-other             5278016      5003584      -5.20

rpc-8                     old          new      delta
gc-pause-one          3938119      2976239     -24.42
gc-pause-total            196          148     -24.49
sys-other             5564736      5273920      -5.23

widefinder-1              old          new      delta
gc-pause-one          6817381      6230830      -8.60

widefinder-8              old          new      delta
gc-pause-one          2829927      2577981      -8.90

http://goperfd.appspot.com/perfdetail?commit=d795425bfa18f01443a556ba896a60
b14c05f420&commit0=7abe32ccffb100a9b9e482a88375baa5d53cebab&kind=builder&
builder=linux-amd64




On Thu, Jan 23, 2014 at 7:57 PM, minux <minux.ma@gmail.com> wrote:

> LGTM.
>