Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(795)

Issue 5601057: code review 5601057: build: remove Make.pkg, Make.tool (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by rsc
Modified:
13 years, 2 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

build: remove Make.pkg, Make.tool Consequently, remove many package Makefiles, and shorten the few that remain. gomake becomes 'go tool make'. Turn off test phases of run.bash that do not work, flagged with $BROKEN. Future CLs will restore these, but this seemed like a big enough CL already.

Patch Set 1 #

Patch Set 2 : diff -r 72133bb4e451 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5707c93b1488 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r b479bc080ad9 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -3464 lines) Patch
M misc/dashboard/builder/Makefile View 1 2 3 1 chunk +4 lines, -9 lines 0 comments Download
M misc/goplay/Makefile View 1 1 chunk +2 lines, -9 lines 0 comments Download
R src/Make.pkg View 1 1 chunk +0 lines, -244 lines 0 comments Download
R src/Make.tool View 1 1 chunk +0 lines, -32 lines 0 comments Download
M src/buildscript/darwin_386.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/darwin_amd64.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript/freebsd_386.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/freebsd_amd64.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/linux_386.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/linux_amd64.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/linux_arm.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/netbsd_386.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/netbsd_amd64.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/openbsd_386.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/openbsd_amd64.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/plan9_386.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/windows_386.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/buildscript/windows_amd64.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/clean.bash View 1 2 1 chunk +13 lines, -6 lines 0 comments Download
M src/cmd/Makefile View 1 2 chunks +1 line, -8 lines 0 comments Download
R src/cmd/cgo/Makefile View 1 1 chunk +0 lines, -16 lines 0 comments Download
R src/cmd/fix/Makefile View 1 1 chunk +0 lines, -53 lines 0 comments Download
R src/cmd/go/Makefile View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
R src/cmd/godoc/Makefile View 1 1 chunk +0 lines, -25 lines 0 comments Download
R src/cmd/gofmt/Makefile View 1 1 chunk +0 lines, -19 lines 0 comments Download
M src/cmd/vet/Makefile View 1 1 chunk +3 lines, -13 lines 0 comments Download
M src/cmd/yacc/Makefile View 1 1 chunk +3 lines, -14 lines 0 comments Download
M src/env.bash View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/make.bash View 1 2 4 chunks +22 lines, -29 lines 0 comments Download
R src/pkg/Makefile View 1 1 chunk +0 lines, -259 lines 0 comments Download
R src/pkg/archive/tar/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/archive/zip/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/bufio/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/bytes/Makefile View 1 1 chunk +0 lines, -16 lines 0 comments Download
R src/pkg/compress/bzip2/Makefile View 1 1 chunk +0 lines, -14 lines 0 comments Download
R src/pkg/compress/flate/Makefile View 1 1 chunk +0 lines, -16 lines 0 comments Download
R src/pkg/compress/gzip/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/compress/lzw/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/compress/zlib/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/container/heap/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/container/list/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/container/ring/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/crypto/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/crypto/aes/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/crypto/cipher/Makefile View 1 1 chunk +0 lines, -17 lines 0 comments Download
R src/pkg/crypto/des/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/crypto/dsa/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/crypto/ecdsa/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/crypto/elliptic/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/crypto/hmac/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/crypto/md5/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/crypto/rand/Makefile View 1 1 chunk +0 lines, -30 lines 0 comments Download
R src/pkg/crypto/rc4/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/crypto/rsa/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/crypto/sha1/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/crypto/sha256/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/crypto/sha512/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/crypto/subtle/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/crypto/tls/Makefile View 1 1 chunk +0 lines, -39 lines 0 comments Download
R src/pkg/crypto/x509/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/crypto/x509/pkix/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/database/sql/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/database/sql/driver/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/debug/dwarf/Makefile View 1 1 chunk +0 lines, -16 lines 0 comments Download
R src/pkg/debug/elf/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/debug/macho/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/debug/pe/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/encoding/ascii85/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
src/pkg/encoding/asn1/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/encoding/base32/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/encoding/base64/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/encoding/binary/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/encoding/csv/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
M src/pkg/encoding/gob/Makefile View 1 1 chunk +4 lines, -20 lines 0 comments Download
M src/pkg/encoding/gob/debug.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
R src/pkg/encoding/hex/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
src/pkg/encoding/json/Makefile View 1 1 chunk +0 lines, -16 lines 0 comments Download
src/pkg/encoding/pem/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/encoding/xml/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/errors/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/exp/ebnf/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/exp/ebnflint/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/exp/gotype/Makefile View 1 1 chunk +0 lines, -17 lines 0 comments Download
R src/pkg/exp/html/Makefile View 1 1 chunk +0 lines, -20 lines 0 comments Download
R src/pkg/exp/inotify/Makefile View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/pkg/exp/norm/Makefile View 1 2 chunks +3 lines, -26 lines 0 comments Download
src/pkg/exp/proxy/Makefile View 1 1 chunk +0 lines, -14 lines 0 comments Download
R src/pkg/exp/terminal/Makefile View 1 1 chunk +0 lines, -16 lines 0 comments Download
R src/pkg/exp/types/Makefile View 1 1 chunk +0 lines, -18 lines 0 comments Download
R src/pkg/exp/utf8string/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
src/pkg/exp/winfsnotify/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
src/pkg/expvar/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/flag/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/fmt/Makefile View 1 1 chunk +0 lines, -14 lines 0 comments Download
R src/pkg/go/ast/Makefile View 1 1 chunk +0 lines, -17 lines 0 comments Download
src/pkg/go/build/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/pkg/go/doc/Makefile View 1 1 chunk +1 line, -16 lines 0 comments Download
src/pkg/go/parser/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/go/printer/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
src/pkg/go/scanner/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/go/token/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
src/pkg/hash/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/hash/adler32/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
src/pkg/hash/crc32/Makefile View 1 1 chunk +0 lines, -20 lines 0 comments Download
R src/pkg/hash/crc64/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/hash/fnv/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/html/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/html/template/Makefile View 1 1 chunk +0 lines, -23 lines 0 comments Download
R src/pkg/image/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/image/color/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/image/draw/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/image/gif/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/image/jpeg/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/image/png/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/index/suffixarray/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
src/pkg/io/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/io/ioutil/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/log/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/log/syslog/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/math/Makefile View 1 1 chunk +0 lines, -77 lines 0 comments Download
R src/pkg/math/big/Makefile View 1 1 chunk +0 lines, -18 lines 0 comments Download
src/pkg/math/cmplx/Makefile View 1 1 chunk +0 lines, -25 lines 0 comments Download
src/pkg/math/rand/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/mime/Makefile View 1 1 chunk +0 lines, -36 lines 0 comments Download
src/pkg/mime/multipart/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/net/Makefile View 1 1 chunk +0 lines, -207 lines 0 comments Download
R src/pkg/net/http/Makefile View 1 1 chunk +0 lines, -25 lines 0 comments Download
R src/pkg/net/http/cgi/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
src/pkg/net/http/fcgi/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/net/http/httptest/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/net/http/httputil/Makefile View 1 1 chunk +0 lines, -14 lines 0 comments Download
R src/pkg/net/http/pprof/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/net/mail/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/net/rpc/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/net/rpc/jsonrpc/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/net/smtp/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/net/textproto/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/net/url/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/old/netchan/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/old/regexp/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
src/pkg/old/template/Makefile View 1 1 chunk +0 lines, -14 lines 0 comments Download
R src/pkg/os/Makefile View 1 1 chunk +0 lines, -92 lines 0 comments Download
R src/pkg/os/exec/Makefile View 1 1 chunk +0 lines, -34 lines 0 comments Download
R src/pkg/os/signal/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/os/user/Makefile View 1 1 chunk +0 lines, -33 lines 0 comments Download
R src/pkg/path/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/path/filepath/Makefile View 1 1 chunk +0 lines, -35 lines 0 comments Download
M src/pkg/path/filepath/path_test.go View 1 1 chunk +4 lines, -4 lines 0 comments Download
R src/pkg/reflect/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/regexp/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/regexp/syntax/Makefile View 1 1 chunk +0 lines, -16 lines 0 comments Download
M src/pkg/runtime/Makefile View 1 2 chunks +5 lines, -117 lines 0 comments Download
src/pkg/runtime/cgo/Makefile View 1 1 chunk +0 lines, -60 lines 0 comments Download
R src/pkg/runtime/debug/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/runtime/pprof/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/sort/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/strconv/Makefile View 1 1 chunk +0 lines, -18 lines 0 comments Download
src/pkg/strings/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/sync/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/sync/atomic/Makefile View 1 1 chunk +0 lines, -18 lines 0 comments Download
R src/pkg/syscall/Makefile View 1 1 chunk +0 lines, -90 lines 0 comments Download
R src/pkg/testing/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
src/pkg/testing/iotest/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/testing/quick/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/testing/script/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
src/pkg/text/scanner/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/text/tabwriter/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
R src/pkg/text/template/Makefile View 1 1 chunk +0 lines, -15 lines 0 comments Download
R src/pkg/text/template/parse/Makefile View 1 1 chunk +0 lines, -13 lines 0 comments Download
R src/pkg/time/Makefile View 1 1 chunk +0 lines, -45 lines 0 comments Download
M src/pkg/unicode/Makefile View 1 1 chunk +2 lines, -20 lines 0 comments Download
R src/pkg/unicode/utf16/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
src/pkg/unicode/utf8/Makefile View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/run.bash View 1 1 chunk +36 lines, -56 lines 0 comments Download
M test/run View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 2 months ago (2012-01-31 04:25:02 UTC) #1
r
LGTM http://codereview.appspot.com/5601057/diff/3/misc/dashboard/builder/Makefile File misc/dashboard/builder/Makefile (right): http://codereview.appspot.com/5601057/diff/3/misc/dashboard/builder/Makefile#newcode5 misc/dashboard/builder/Makefile:5: gobuilder: $(shell ls *.go) i don't know this ...
13 years, 2 months ago (2012-01-31 04:37:58 UTC) #2
rsc
13 years, 2 months ago (2012-01-31 04:43:46 UTC) #3
*** Submitted as c1799a84a1d4 ***

build: remove Make.pkg, Make.tool

Consequently, remove many package Makefiles,
and shorten the few that remain.

gomake becomes 'go tool make'.

Turn off test phases of run.bash that do not work,
flagged with $BROKEN.  Future CLs will restore these,
but this seemed like a big enough CL already.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5601057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b