Issue 5601054: code review 5601054: go.image/{bmp,tiff}: move tiff/testdata to testdata.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5601054: code review 5601054: go.image/{bmp,tiff}: move tiff/testdata to testdata. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by nigeltao

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go.image/{bmp,tiff}: move tiff/testdata to testdata. Add a "compare to golden PNG" test for BMP and TIFF.

Patch Set 1 #

Patch Set 2 : diff -r 726a48eb7716 https://code.google.com/p/go.image #

Patch Set 3 : diff -r 726a48eb7716 https://code.google.com/p/go.image #

Patch Set 4 : diff -r 726a48eb7716 https://code.google.com/p/go.image #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -23 lines)			Patch
A	bmp/reader_test.go	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download
M	testdata/bw-deflate.tiff	View	1	Binary file		0 comments	Download
M	testdata/bw-packbits.tiff	View	1	Binary file		0 comments	Download
M	testdata/bw-uncompressed.tiff	View	1	Binary file		0 comments	Download
M	testdata/no_rps.tiff	View	1	Binary file		0 comments	Download
A	testdata/video-001.bmp	View	1	Binary file		0 comments	Download
A	testdata/video-001.png	View	1	Binary file		0 comments	Download
A	testdata/video-001.tiff	View	1	Binary file		0 comments	Download
M	testdata/video-001-uncompressed.tiff	View	1	Binary file		0 comments	Download
M	tiff/reader_test.go	View	1	6 chunks	+57 lines, -23 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image

13 years, 1 month ago (2012-01-31 01:26:08 UTC) #1

nigeltao

13 years, 1 month ago (2012-01-31 03:02:45 UTC) #3

*** Submitted as ce578805294d ***

go.image/{bmp,tiff}: move tiff/testdata to testdata.

Add a "compare to golden PNG" test for BMP and TIFF.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5601054

Expand All Messages | Collapse All Messages