Issue 55980046: code review 55980046: effective_go: move 'Type switch' section into 'Control ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55980046: code review 55980046: effective_go: move 'Type switch' section into 'Control ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by r

Modified:
11 years, 1 month ago

Reviewers:
dsymonds

CC:
golang-codereviews, dsymonds

Visibility:
Public.

Description

effective_go: move 'Type switch' section into 'Control structures' section. Needs to be an h3, not an h2. Thanks to Mingjie Xing for pointing it out.

Patch Set 1 #

Patch Set 2 : diff -r 0ba5ecac8038 https://code.google.com/p/go #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	doc/effective_go.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 1 month ago (2014-01-23 23:48:44 UTC) #1

11 years, 1 month ago (2014-01-24 00:25:21 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0dff07f88a28 ***

effective_go: move 'Type switch' section into 'Control structures' section.
Needs to be an h3, not an h2.
Thanks to Mingjie Xing for pointing it out.

LGTM=dsymonds
R=golang-codereviews, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/55980046

Expand All Messages | Collapse All Messages