code review 5593046: net: replace error variable name e, errno with err

net: replace error variable name e, errno with err

[mikio, 2012-01-29 13:04:07]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-01-29 16:08:20]

i'm less sure about this one. local consistency is broken in a number of these
files

and why netfd->nfd?

[rsc, 2012-01-29 17:44:45]

Thanks.  This looks reasonable.
If a function returns more than one non-error result,
especially if the multiple results are the same type,
then the names really help a lot and should be preserved.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_freebsd.go
File src/pkg/net/fd_freebsd.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_freebsd.go#new...
src/pkg/net/fd_freebsd.go:80: func (p *pollster) WaitFD(s *pollServer, nsec
int64) (int, int, error) {
The names were a big help here before: they made clear what
the function returned.  Please restore them.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_linux.go
File src/pkg/net/fd_linux.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_linux.go#newco...
src/pkg/net/fd_linux.go:137: func (p *pollster) WaitFD(s *pollServer, nsec
int64) (int, int, error) {
Same.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_netbsd.go
File src/pkg/net/fd_netbsd.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_netbsd.go#newc...
src/pkg/net/fd_netbsd.go:80: func (p *pollster) WaitFD(s *pollServer, nsec
int64) (int, int, error) {
Same.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_openbsd.go
File src/pkg/net/fd_openbsd.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_openbsd.go#new...
src/pkg/net/fd_openbsd.go:80: func (p *pollster) WaitFD(s *pollServer, nsec
int64) (int, int, error) {
Same.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/interface_darwin.go
File src/pkg/net/interface_darwin.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/interface_darwin....
src/pkg/net/interface_darwin.go:18: var (
If you're going to clean this up, please get rid of these var blocks.
Variable declarations should be postponed until they are necessary,
unlike in C.

In this function, that would mean using := for the two syscall calls
and then declaring var ifmat []Addr just before the for loop.

There are others lurking: grep for 'var ('.
Thanks.

[mikio, 2012-01-31 14:01:37]

Thank you fot the review.

> and why netfd->nfd?

just pick it from f, fd, nfd and netfd.
changed to netfd.

> If a function returns more than one non-error result,
> especially if the multiple results are the same type,
> then the names really help a lot and should be preserved.

agreed.

> If you're going to clean this up, please get rid of these var blocks.
> Variable declarations should be postponed until they are necessary,
> unlike in C.

will try.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_freebsd.go
File src/pkg/net/fd_freebsd.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_freebsd.go#new...
src/pkg/net/fd_freebsd.go:80: func (p *pollster) WaitFD(s *pollServer, nsec
int64) (int, int, error) {
On 2012/01/29 17:44:45, rsc wrote:
> The names were a big help here before: they made clear what
> the function returned.  Please restore them.
> 
> 

Done.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_linux.go
File src/pkg/net/fd_linux.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_linux.go#newco...
src/pkg/net/fd_linux.go:137: func (p *pollster) WaitFD(s *pollServer, nsec
int64) (int, int, error) {
On 2012/01/29 17:44:45, rsc wrote:
> Same.

Done.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_netbsd.go
File src/pkg/net/fd_netbsd.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/fd_netbsd.go#newc...
src/pkg/net/fd_netbsd.go:80: func (p *pollster) WaitFD(s *pollServer, nsec
int64) (int, int, error) {
On 2012/01/29 17:44:45, rsc wrote:
> Same.

Done.

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/interface_darwin.go
File src/pkg/net/interface_darwin.go (right):

http://codereview.appspot.com/5593046/diff/4052/src/pkg/net/interface_darwin....
src/pkg/net/interface_darwin.go:18: var (
On 2012/01/29 17:44:45, rsc wrote:
> If you're going to clean this up, please get rid of these var blocks.
> Variable declarations should be postponed until they are necessary,
> unlike in C.
> 
> In this function, that would mean using := for the two syscall calls
> and then declaring var ifmat []Addr just before the for loop.
> 
> There are others lurking: grep for 'var ('.
> Thanks.

Done.

[mikio, 2012-01-31 14:02:00]

Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-31 15:32:03]

LGTM

http://codereview.appspot.com/5593046/diff/13002/src/pkg/net/ipsock_plan9.go
File src/pkg/net/ipsock_plan9.go (right):

http://codereview.appspot.com/5593046/diff/13002/src/pkg/net/ipsock_plan9.go#...
src/pkg/net/ipsock_plan9.go:26: addr = IPv4zero // address contains port only
addr := IPv4zero

[mikio, 2012-01-31 15:36:50]

*** Submitted as http://code.google.com/p/go/source/detail?r=546d24e10463 ***

net: replace error variable name e, errno with err

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5593046