Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 55810044: code review 55810044: runtime: Print elision message if we skipped frames on ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by khr
Modified:
11 years, 1 month ago
Reviewers:
dvyukov
CC:
golang-codereviews, dvyukov, gri
Visibility:
Public.

Description

runtime: Print elision message if we skipped frames on traceback. Fixes bug 7180

Patch Set 1 #

Patch Set 2 : diff -r e8977a85a0e8 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r e8977a85a0e8 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r e8977a85a0e8 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 847f3d4e7104 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M src/pkg/runtime/runtime.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/runtime/traceback_arm.c View 1 2 chunks +7 lines, -2 lines 0 comments Download
M src/pkg/runtime/traceback_x86.c View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4
khr
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
11 years, 1 month ago (2014-01-22 22:44:34 UTC) #1
khr
On 2014/01/22 22:44:34, khr wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
11 years, 1 month ago (2014-01-22 22:45:45 UTC) #2
dvyukov
LGTM
11 years, 1 month ago (2014-01-23 08:41:47 UTC) #3
khr
11 years, 1 month ago (2014-01-23 20:47:32 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=0ba5ecac8038 ***

runtime: Print elision message if we skipped frames on traceback.

Fixes bug 7180

R=golang-codereviews, dvyukov
CC=golang-codereviews, gri
https://codereview.appspot.com/55810044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b