Issue 5577060: code review 5577060: weekly.2012-01-27

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5577060: code review 5577060: weekly.2012-01-27 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by adg

Modified:
12 years, 3 months ago

Reviewers:
lvd

CC:
golang-dev, dsymonds

Visibility:
Public.

Patch Set 2 : diff -r 9f95fc15702a https://go.googlecode.com/hg #

Patch Set 3 : diff -r 9f95fc15702a https://go.googlecode.com/hg #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -1 line)			Patch
	M	.hgtags	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/weekly.html	View		1 chunk	+107 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 3 months ago (2012-01-27 05:45:33 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/5577060/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5577060/diff/1/doc/devel/weekly.html#newcode110 doc/devel/weekly.html:110: * net: Dial, ListenPacket with "ip:protocol" network for ...

12 years, 3 months ago (2012-01-27 05:48:52 UTC) #2

adg

On 27 January 2012 16:48, <dsymonds@golang.org> wrote: > LGTM > > > http://codereview.appspot.com/5577060/diff/1/doc/devel/weekly.html > File ...

12 years, 3 months ago (2012-01-27 06:51:15 UTC) #3

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=1107a7d3cb07 *** weekly.2012-01-27 R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/5577060

12 years, 3 months ago (2012-01-27 06:52:00 UTC) #4

lvd

12 years, 3 months ago (2012-01-27 08:48:53 UTC) #5

http://codereview.appspot.com/5577060/diff/1/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5577060/diff/1/doc/devel/weekly.html#newcode38
doc/devel/weekly.html:38: * cmd/gc: forgotten recursion on ninit itself in
order.c.
this can go with the other gc stuff below.

Expand All Messages | Collapse All Messages