Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(410)

Issue 5574065: code review 5574065: go.net: initial code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by rsc
Modified:
12 years, 3 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

go.net: initial code Manual edits to README. Moved from main Go repository, deleted Makefiles, ran gofix -r go1rename. Tested with: go test code.google.com/p/go.net/...

Patch Set 1 #

Patch Set 2 : diff -r b50a7fb49394 https://code.google.com/p/go.net #

Patch Set 3 : diff -r b50a7fb49394 https://code.google.com/p/go.net #

Patch Set 4 : diff -r b50a7fb49394 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4629 lines, -15 lines) Patch
M README View 1 1 chunk +2 lines, -15 lines 0 comments Download
A dict/dict.go View 1 1 chunk +210 lines, -0 lines 0 comments Download
A spdy/read.go View 1 1 chunk +312 lines, -0 lines 0 comments Download
A spdy/spdy_test.go View 1 1 chunk +497 lines, -0 lines 0 comments Download
A spdy/types.go View 1 1 chunk +369 lines, -0 lines 0 comments Download
A spdy/write.go View 1 1 chunk +285 lines, -0 lines 0 comments Download
A websocket/client.go View 1 1 chunk +137 lines, -0 lines 0 comments Download
A websocket/hixie.go View 1 1 chunk +695 lines, -0 lines 0 comments Download
A websocket/hixie_test.go View 1 1 chunk +201 lines, -0 lines 0 comments Download
A websocket/hybi.go View 1 1 chunk +549 lines, -0 lines 0 comments Download
A websocket/hybi_test.go View 1 1 chunk +584 lines, -0 lines 0 comments Download
A websocket/server.go View 1 1 chunk +102 lines, -0 lines 0 comments Download
A websocket/websocket.go View 1 1 chunk +412 lines, -0 lines 0 comments Download
A websocket/websocket_test.go View 1 1 chunk +274 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.net
12 years, 3 months ago (2012-01-25 20:19:34 UTC) #1
bradfitz
LGTM On Wed, Jan 25, 2012 at 12:19 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
12 years, 3 months ago (2012-01-25 20:28:09 UTC) #2
rsc
12 years, 3 months ago (2012-01-25 20:31:32 UTC) #3
*** Submitted as 3f1ea60efedc ***

go.net: initial code

Manual edits to README.
Moved from main Go repository, deleted Makefiles, ran gofix -r go1rename.

Tested with: go test code.google.com/p/go.net/...

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5574065
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b