Issue 5574057: code review 5574057: encoding/xml: remove Marshaler support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5574057: code review 5574057: encoding/xml: remove Marshaler support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by niemeyer

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

encoding/xml: remove Marshaler support Marshaler has a number of open areas that need further thought (e.g. it doesn't handle attributes, it's supposed to handle tag names internally but has no information to do so, etc). We're removing it now and will bring it back with an interface that covers these aspects, after Go 1. Related to issue 2771, but doesn't fix it.

Patch Set 1 #

Patch Set 2 : code review 5574057: encoding/xml: remove Marshaler support #

Patch Set 3 : diff -r c0d32b240d3d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c0d32b240d3d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 60013c96035b https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -33 lines)			Patch
	M	src/pkg/encoding/xml/marshal.go	View	1 2	2 chunks	+0 lines, -20 lines	0 comments	Download
	M	src/pkg/encoding/xml/marshal_test.go	View	1 2	2 chunks	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-01-24 23:14:30 UTC) #1

niemeyer

13 years, 3 months ago (2012-01-24 23:51:22 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=20a3a96e61b2 ***

encoding/xml: remove Marshaler support

Marshaler has a number of open areas that need
further thought (e.g. it doesn't handle attributes,
it's supposed to handle tag names internally but has
no information to do so, etc).

We're removing it now and will bring it back with an
interface that covers these aspects, after Go 1.

Related to issue 2771, but doesn't fix it.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5574057

Expand All Messages | Collapse All Messages