Issue 5574045: code review 5574045: gc: missed typecheck in subscripting a const string.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5574045: code review 5574045: gc: missed typecheck in subscripting a const string. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by lvd

Modified:
13 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gc: missed typecheck in subscripting a const string. Fixes issue 2674.

Patch Set 1 #

Patch Set 2 : diff -r 63a6abde14b1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 63a6abde14b1 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 882ec620945a https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	src/cmd/gc/walk.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	A	test/fixedbugs/bug399.go	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lvd

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-01-23 14:14:40 UTC) #1

lvd

13 years, 2 months ago (2012-01-23 15:57:14 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=44abf78c0f28 ***

gc: missed typecheck in subscripting a const string.

Fixes issue 2674.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5574045

Expand All Messages | Collapse All Messages