Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6775)

Issue 5572056: code review 5572056: go.empty: prototype for new subrepository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by rsc
Modified:
5 years, 10 months ago
Reviewers:
r, qa8302, elibohr27
CC:
golang-dev, r
Visibility:
Public.

Description

go.empty: prototype for new subrepository

Patch Set 1 #

Patch Set 2 : diff -r 0 default #

Total comments: 1

Patch Set 3 : diff -r 0 https://code.google.com/p/go.empty/ #

Patch Set 4 : diff -r 0 https://code.google.com/p/go.empty/ #

Patch Set 5 : diff -r 0 https://code.google.com/p/go.empty/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
A .hgignore View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A AUTHORS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A CONTRIBUTORS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A README View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A codereview.cfg View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to default
12 years, 2 months ago (2012-01-24 20:28:39 UTC) #1
r
http://codereview.appspot.com/5572056/diff/2001/README File README (right): http://codereview.appspot.com/5572056/diff/2001/README#newcode14 README:14: use the usual hg change, mail, submit to send ...
12 years, 2 months ago (2012-01-24 20:47:21 UTC) #2
rsc
On Tue, Jan 24, 2012 at 15:47, <r@golang.org> wrote: > will someone need to set ...
12 years, 2 months ago (2012-01-24 20:51:52 UTC) #3
r
by the way, LGTM but someone more code-social should probably agree
12 years, 2 months ago (2012-01-24 22:00:02 UTC) #4
rsc
*** Submitted as b50a7fb49394 *** go.empty: prototype for new subrepository R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5572056
12 years, 2 months ago (2012-01-25 19:45:15 UTC) #5
elibohr27
On 2012super, /01/24 20:51:52, rsc wrote: > On Tue, Jan 24, 2012 at 15:47, <mailto:r@golang.org> ...
7 years, 3 months ago (2017-01-02 02:39:31 UTC) #6
elibohr27
7 years, 3 months ago (2017-01-02 02:44:18 UTC) #7
elibohr27
7 years, 3 months ago (2017-01-02 02:44:20 UTC) #8
elibohr27
7 years, 3 months ago (2017-01-02 02:48:32 UTC) #9
elibohr27
7 years, 3 months ago (2017-01-02 02:50:21 UTC) #10
elibohr27
On 2012/01/24 22:00:02, r wrote: > by the way, LGTM but someone more code-social should ...
7 years, 3 months ago (2017-01-02 02:53:45 UTC) #11
qa8302
5 years, 10 months ago (2018-06-11 09:36:03 UTC) #12
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b