code review 5571062: net/rpc: fix race in TestClientWriteError test

net/rpc: fix race in TestClientWriteError test
Fixes issue 2752.

[dvyukov, 2012-01-25 13:47:51]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
mpimenov@google.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mpimenov, 2012-01-25 14:36:25]

http://codereview.appspot.com/5571062/diff/2001/src/pkg/net/rpc/server_test.go
File src/pkg/net/rpc/server_test.go (right):

http://codereview.appspot.com/5571062/diff/2001/src/pkg/net/rpc/server_test.g...
src/pkg/net/rpc/server_test.go:497: }
Don't you need c.Close() here?

[dvyukov, 2012-01-25 14:43:47]

http://codereview.appspot.com/5571062/diff/2001/src/pkg/net/rpc/server_test.go
File src/pkg/net/rpc/server_test.go (right):

http://codereview.appspot.com/5571062/diff/2001/src/pkg/net/rpc/server_test.g...
src/pkg/net/rpc/server_test.go:497: }
On 2012/01/25 14:36:25, mpimenov wrote:
> Don't you need c.Close() here?

What for?

[r, 2012-01-25 18:47:41]

LGTM

http://codereview.appspot.com/5571062/diff/2001/src/pkg/net/rpc/server_test.go
File src/pkg/net/rpc/server_test.go (right):

http://codereview.appspot.com/5571062/diff/2001/src/pkg/net/rpc/server_test.g...
src/pkg/net/rpc/server_test.go:497: }
agree with dvyukov here, it's totally unnecessary.

[dvyukov, 2012-01-26 07:37:48]

*** Submitted as http://code.google.com/p/go/source/detail?r=51c8b6d6dbe2 ***

net/rpc: fix race in TestClientWriteError test
Fixes issue 2752.

R=golang-dev, mpimenov, r
CC=golang-dev
http://codereview.appspot.com/5571062

[dvyukov, 2012-01-26 07:39:17]

On 2012/01/25 18:47:41, r wrote:
>
http://codereview.appspot.com/5571062/diff/2001/src/pkg/net/rpc/server_test.g...
> src/pkg/net/rpc/server_test.go:497: }
> agree with dvyukov here, it's totally unnecessary.

Per offline discussion with Maxim, he pointed out that Client.Close() is never
called in tests, so it's non evident that it works.