code review 5571061: godoc: new design

godoc: new design

This is not the finished product,
but a good checkpoint from which to
proceed with further development.

[adg, 2012-02-13 05:57:33]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2012-02-13 05:58:41]

tests?

[r2, 2012-02-13 07:24:16]

LGTM assuming this is a checkpoint for further development.
dsymonds can write the tests.

-rob

[adg, 2012-02-13 10:22:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=b0d5812e0b23 ***

godoc: new design

This is not the finished product,
but a good checkpoint from which to
proceed with further development.

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5571061

[adg, 2012-02-13 10:38:38]

Please assign any issues about the new design to me.

[sanjay.m, 2012-02-13 10:48:31]

This is breaking tip.golang.org. Pages link to all.css, which is giving a 
404, but those pages should be referencing style.css with this CL.

Presumably, instances need to be restarted to use the new html template?

Sanjay

[bradfitz, 2012-02-13 10:50:51]

Yup. Will do tomorrow.

On Mon, Feb 13, 2012 at 2:48 AM, sanjay.m <balasanjay@gmail.com> wrote:

> This is breaking tip.golang.org. Pages link to all.css, which is giving a
> 404, but those pages should be referencing style.css with this CL.
>
> Presumably, instances need to be restarted to use the new html template?
>
> Sanjay
>

[roberto_costumero.es, 2012-02-13 11:43:57]

I am doing some tests to fix my CL on the GOPATH import problem and I have
found several issues.

- "src" from a GOPATH directory does not contain any link, but can be
accessed at src/.

- $GOPATH/pkg information is not shown under localhost/pkg directory. I
would expect to see the "widgets/foo" package I've created.

- Executing go install inside $GOPATH/src creates the directories under
$GOPATH/pkg but does not install correctly the package (foo.a is missing).

- There's a typo on doc/code.html on the "The go tool and GOPATH" section:
ls $GOPATH/pkg/*/example should be ls $GOPATH/pkg/*/widgets.

Should I fill an issue for each on the issue tracker? If I can contribute
by changing anything let me know and I will do it.



On Mon, Feb 13, 2012 at 11:50, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> Yup. Will do tomorrow.
>
>
> On Mon, Feb 13, 2012 at 2:48 AM, sanjay.m <balasanjay@gmail.com> wrote:
>
>> This is breaking tip.golang.org. Pages link to all.css, which is giving
>> a 404, but those pages should be referencing style.css with this CL.
>>
>> Presumably, instances need to be restarted to use the new html template?
>>
>> Sanjay
>>
>
>

[dchest, 2012-02-13 15:37:53]

doc/gopher/frontpage.png

Background color of this image is #fefefe, while the page is white.

[rcostu, 2012-02-13 17:00:40]

doc/install.html is out-dated, showing 6g, 6l... instead of Go 1 tools.

On Mon, Feb 13, 2012 at 16:37, <dchest@gmail.com> wrote:

> doc/gopher/frontpage.png
>
> Background color of this image is #fefefe, while the page is white.
>
>
http://codereview.appspot.com/**5571061/<http://codereview.appspot.com/5571061/>
>

[adg, 2012-02-13 21:02:23]

On 14 February 2012 04:00, Roberto Costumero Moreno <rcostu@gmail.com> wrote:
> doc/install.html is out-dated, showing 6g, 6l... instead of Go 1 tools.

http://golang.org/cl/5605047